Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

bump capi and providers with provider folder manually rebased#3752

Closed
jeffwubj wants to merge 0 commit intomainfrom
topic/jeffwubj/bump-capi-and-providers-rename
Closed

bump capi and providers with provider folder manually rebased#3752
jeffwubj wants to merge 0 commit intomainfrom
topic/jeffwubj/bump-capi-and-providers-rename

Conversation

@jeffwubj
Copy link
Copy Markdown
Contributor

@jeffwubj jeffwubj commented Oct 25, 2022

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Additional information

Special notes for your reviewer

@jeffwubj jeffwubj requested a review from a team as a code owner October 25, 2022 23:08
@jeffwubj jeffwubj requested a review from a team October 25, 2022 23:08
@jeffwubj jeffwubj requested a review from prkalle as a code owner October 25, 2022 23:08
@jeffwubj jeffwubj requested review from a team October 25, 2022 23:08
@jeffwubj jeffwubj requested a review from a team as a code owner October 25, 2022 23:08
@jeffwubj
Copy link
Copy Markdown
Contributor Author

jeffwubj commented Oct 25, 2022 •
edited
Loading

//usebom:sandbox/v1.7.0-zshippable/431703182511446831/tkg-compatibility:v12

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 25, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3752/20221025232310/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@jeffwubj jeffwubj changed the title bump capi and providers with provider folder name renamed back to rebase bump capi and providers with provider folder manually rebased Oct 26, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 26, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3752/20221026050350/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 26, 2022 •
edited
Loading

Codecov Report

Merging #3752 (e3e9f7e) into main (485f0ce) will decrease coverage by 0.84%.
The diff coverage is 66.66%.

❗ Current head e3e9f7e differs from pull request most recent head 891d4e4. Consider uploading reports for the commit 891d4e4 to get more accurate results

@@            Coverage Diff             @@
##             main    #3752      +/-   ##
==========================================
- Coverage   46.58%   45.74%   -0.85%     
==========================================
  Files         400      425      +25     
  Lines       39722    41291    +1569     
==========================================
+ Hits        18504    18888     +384     
- Misses      19519    20692    +1173     
- Partials     1699     1711      +12
Impacted Files Coverage Δ
tkg/client/init.go 0.00% <0.00%> (ø)
tkg/client/machine_deployment.go 61.86% <ø> (ø)
tkg/client/upgrade_cluster.go 44.62% <66.66%> (ø)
tkg/clusterclient/clusterclient.go 49.34% <85.71%> (ø)
...in/cluster/set_machinehealthcheck_control_plane.go 21.21% <0.00%> (ø)
...md/cli/plugin/cluster/delete_machinehealthcheck.go 19.23% <0.00%> (ø)
cmd/cli/plugin/cluster/delete_node_pool.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/set_machinehealthcheck.go 23.33% <0.00%> (ø)
...i/plugin/cluster/delete_machinehealthcheck_node.go 16.66% <0.00%> (ø)
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jeffwubj jeffwubj force-pushed the topic/jeffwubj/bump-capi-and-providers-rename branch from 51ff9e3 to e91478d Compare October 27, 2022 04:14
@srm09 srm09 mentioned this pull request Oct 27, 2022
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 27, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3752/20221027042935/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@jeffwubj jeffwubj mentioned this pull request Oct 27, 2022
Closed
@marckhouzam
Copy link
Copy Markdown
Contributor

marckhouzam commented Oct 27, 2022

This needs a rebase

@marckhouzam marckhouzam mentioned this pull request Oct 27, 2022
Closed
@imikushin
Copy link
Copy Markdown
Contributor

imikushin commented Oct 27, 2022

Pushed a commit resolving conflicts with main.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 27, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3752/20221027194020/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@imikushin imikushin mentioned this pull request Oct 27, 2022
Closed
imikushin
imikushin approved these changes Oct 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@imikushin imikushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 28, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3752/20221028083633/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@jeffwubj jeffwubj force-pushed the topic/jeffwubj/bump-capi-and-providers-rename branch from 57cf645 to 891d4e4 Compare October 28, 2022 08:41
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 28, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3752/20221028085238/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@jeffwubj jeffwubj closed this Oct 28, 2022
@jeffwubj jeffwubj force-pushed the topic/jeffwubj/bump-capi-and-providers-rename branch from 891d4e4 to e20eb8d Compare October 28, 2022 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@prkalle prkalle Awaiting requested review from prkalle

1 more reviewer

@imikushin imikushin imikushin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeffwubj @marckhouzam @imikushin @vmwclabot