Bump Cluster API and providers by ykakarap · Pull Request #3699 · vmware-tanzu/tanzu-framework

ykakarap · 2022-10-18T22:36:29Z

What this PR does / why we need it

This PR bumps the version of ClusterAPI and the providers.

Go dependencies will be merged in #3157

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Additional information

Special notes for your reviewer

github-actions · 2022-10-18T22:48:29Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3699/20221018224827/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

ykakarap · 2022-10-19T02:52:32Z

//usebom:sandbox/v1.7.0-zshippable/430495289984455744/tkg-compatibility:v12

wjun · 2022-10-19T10:23:53Z

Please fix the errors in main/build, capd cc, and capa cc pipelines.

github-actions · 2022-10-20T00:58:13Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3699/20221020005811/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-10-20T02:09:46Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3699/20221020020944/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-10-20T02:53:28Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3699/20221020025326/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

ykakarap · 2022-10-20T05:11:58Z

//usebom:sandbox/v1.7.0-zshippable/430679015683004628/tkg-compatibility:v12

wjun · 2022-10-20T12:22:15Z

Please rebase to main branch with a reverted merge that blocked ClusterClass related pipeline tests.

randomvariable · 2022-10-20T16:34:12Z

rebased

github-actions · 2022-10-20T16:44:16Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3699/20221020164413/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

ykakarap · 2022-10-20T18:51:47Z

rebased

Thank you!

ykakarap · 2022-10-21T04:16:24Z

//usebom:sandbox/v1.7.0-zshippable/430776759441430622/tkg-compatibility:v12

github-actions · 2022-10-21T19:41:48Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3699/20221021194146/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

codecov · 2022-10-21T20:45:16Z

Codecov Report

Merging #3699 (af92df5) into main (863aba1) will decrease coverage by 0.82%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #3699      +/-   ##
==========================================
- Coverage   46.22%   45.40%   -0.83%     
==========================================
  Files         400      425      +25     
  Lines       39642    41198    +1556     
==========================================
+ Hits        18326    18706     +380     
- Misses      19626    20792    +1166     
- Partials     1690     1700      +10

Impacted Files	Coverage Δ
tkg/client/init.go	`0.00% <0.00%> (ø)`
tkg/client/machine_deployment.go	`61.86% <ø> (ø)`
tkg/client/upgrade_cluster.go	`43.05% <66.66%> (ø)`
tkg/clusterclient/clusterclient.go	`48.79% <85.71%> (ø)`
cmd/cli/plugin/cluster/machinehealthcheck.go	`100.00% <0.00%> (ø)`
cmd/cli/plugin/cluster/scale.go	`17.85% <0.00%> (ø)`
cmd/cli/plugin/cluster/kubeconfig_get.go	`8.82% <0.00%> (ø)`
cmd/cli/plugin/cluster/get_machinehealthcheck.go	`11.42% <0.00%> (ø)`
...in/cluster/set_machinehealthcheck_control_plane.go	`21.21% <0.00%> (ø)`
...in/cluster/get_machinehealthcheck_control_plane.go	`11.11% <0.00%> (ø)`
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Sagar Muchhal <[email protected]>

Signed-off-by: Ashutosh Kumar <[email protected]>

srm09 · 2022-10-26T19:51:21Z

Removed the CAPA 2.0.0 bump from the patch. Also, removed the fixes for the pipelines made for the CAPA bumps.

github-actions · 2022-10-26T20:06:52Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3699/20221026200649/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

(cherry picked from commit 3218a76)

(cherry picked from commit 002f19f)

This patch changes the overlays to include the customization of the subnets for cluster creation only when using a custom VPC. The overlays now check for the presence of the VPC ID and the public/private subnet ID, before including those blocks for cluster YAML creation. Since, the public/private subnets can be used only when using a custom VPC. Otherwise we leave the AWSCluster.spec.network.subnets slice empty and let CAPA handle the creation of the resources. Signed-off-by: Sagar Muchhal <[email protected]>

github-actions · 2022-10-26T22:20:04Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3699/20221026222001/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

srm09 · 2022-10-27T04:23:55Z

Will eventually close this in favor of #3752
/hold

ykakarap · 2022-11-07T20:05:05Z

Closing this PR in favor of #3772

ykakarap requested a review from a team as a code owner October 18, 2022 22:36

ykakarap requested a review from a team October 18, 2022 22:36

ykakarap requested a review from prkalle as a code owner October 18, 2022 22:36

ykakarap requested review from a team October 18, 2022 22:36

ykakarap requested a review from a team as a code owner October 18, 2022 22:36

vmwclabot added the cla-not-required label Oct 18, 2022

ykakarap mentioned this pull request Oct 18, 2022

[WIP] Bump Cluster API and providers #3513

Closed

srm09 force-pushed the bump-capi-and-providers branch from 39950d3 to 177938a Compare October 20, 2022 00:46

ykakarap force-pushed the bump-capi-and-providers branch from b2bb97a to d5f5506 Compare October 20, 2022 02:44

randomvariable force-pushed the bump-capi-and-providers branch from d5f5506 to 896a068 Compare October 20, 2022 16:34

randomvariable mentioned this pull request Oct 20, 2022

Bump Cobra from 1.5.0 to 1.6.1 #3695

Closed

randomvariable mentioned this pull request Oct 20, 2022

Bump github.com/google/gnostic from 0.5.7-v3refs to 0.6.9 in /addons #3704

Closed

randomvariable approved these changes Oct 20, 2022

View reviewed changes

ykakarap force-pushed the bump-capi-and-providers branch from 896a068 to af92df5 Compare October 21, 2022 19:33

Yuvaraj Kakaraparthi and others added 8 commits October 26, 2022 12:43

Bump CAPI to v1.2.3

e3422ec

Bump CAPV to v1.4.1

f161ea1

Signed-off-by: Sagar Muchhal <[email protected]>

bump capz to v1.5.2

ce9298a

Signed-off-by: Ashutosh Kumar <[email protected]>

update CAPI yamls to v1.2.4

480bb4d

update CAPI go deps to v1.2.4

6788e0f

bump capz to v1.5.3

9e283cf

Signed-off-by: Ashutosh Kumar <[email protected]>

fix packages

046e22f

fix for pipelines

da525be

srm09 force-pushed the bump-capi-and-providers branch from af92df5 to da525be Compare October 26, 2022 19:50

sedefsavas and others added 3 commits October 26, 2022 15:01

Bump CAPA to v2.0.0-beta.1 (v1beta2)

37111fd

(cherry picked from commit 3218a76)

update UT with new aws IAM

729f16d

(cherry picked from commit 002f19f)

jeffwubj mentioned this pull request Nov 1, 2022

Bump CAPI with rebased contents #3772

Merged

ykakarap closed this Nov 7, 2022

xiaoping8385 deleted the bump-capi-and-providers branch December 6, 2022 06:28

Conversation

ykakarap commented Oct 18, 2022

What this PR does / why we need it

Which issue(s) this PR fixes

Describe testing done for PR

Release note

Additional information

Special notes for your reviewer

Uh oh!

github-actions Bot commented Oct 18, 2022

Uh oh!

ykakarap commented Oct 19, 2022

Uh oh!

wjun commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2022

Uh oh!

github-actions Bot commented Oct 20, 2022

Uh oh!

github-actions Bot commented Oct 20, 2022

Uh oh!

ykakarap commented Oct 20, 2022

Uh oh!

wjun commented Oct 20, 2022

Uh oh!

randomvariable commented Oct 20, 2022

Uh oh!

github-actions Bot commented Oct 20, 2022

Uh oh!

ykakarap commented Oct 20, 2022

Uh oh!

ykakarap commented Oct 21, 2022

Uh oh!

github-actions Bot commented Oct 21, 2022

Uh oh!

codecov Bot commented Oct 21, 2022

Codecov Report

Uh oh!

srm09 commented Oct 26, 2022

Uh oh!

github-actions Bot commented Oct 26, 2022

Uh oh!

github-actions Bot commented Oct 26, 2022

Uh oh!

srm09 commented Oct 27, 2022

Uh oh!

ykakarap commented Nov 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

wjun commented Oct 19, 2022 •

edited

Loading