Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Update to Cluster API v1.2.3 in go dependencies#3157

Merged
randomvariable merged 5 commits intovmware-tanzu:mainfrom
randomvariable:capi-update
Oct 12, 2022
Merged

Update to Cluster API v1.2.3 in go dependencies#3157
randomvariable merged 5 commits intovmware-tanzu:mainfrom
randomvariable:capi-update

Conversation

@randomvariable
Copy link
Copy Markdown
Contributor

@randomvariable randomvariable commented Aug 18, 2022 •
edited
Loading

What this PR does / why we need it

  • Update Cluster API and related dependencies to v1.2.3

The providers itself will be updated in a separate PR (#3513). The API changes are compatible.

Fixes # N/A

Describe testing done for PR

Release note

Update Cluster API go dependencies to v1.2.3, controller-runtime to 0.12 and Kubernetes to 1.24
For AWS, the following actions have been added to the policy for Cluster API AWS controllers:
* ec2:ReplaceRoute
* elasticloadbalancing:DeleteTargetGroup

Additional information

Special notes for your reviewer

randomvariable
randomvariable commented Aug 18, 2022
View reviewed changes
Comment thread pkg/v1/tkg/client/machine_deployment_cc.go
@randomvariable
Copy link
Copy Markdown
Contributor Author

randomvariable commented Aug 18, 2022 •
edited
Loading

E2Es are likely to fail because Tanzu's kind image is out of date. Will dig into details in a bit.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 18, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20220818180513/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@sbueringer
Copy link
Copy Markdown

sbueringer commented Aug 18, 2022

Lgtm so far

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 18, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20220818195954/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 18, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20220818200715/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable randomvariable mentioned this pull request Aug 18, 2022
Closed
@randomvariable randomvariable marked this pull request as ready for review September 8, 2022 14:17
@randomvariable randomvariable requested a review from a team as a code owner September 8, 2022 14:17
@randomvariable randomvariable requested review from a team September 8, 2022 14:17
@randomvariable randomvariable requested a review from a team as a code owner September 8, 2022 14:17
@randomvariable randomvariable requested a review from a team September 8, 2022 14:17
marckhouzam
marckhouzam reviewed Sep 8, 2022
View reviewed changes
Comment thread cli/runtime/hack/tools/go.mod
@randomvariable randomvariable force-pushed the capi-update branch 2 times, most recently from cb61284 to 2d848a8 Compare September 8, 2022 14:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 8, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20220908143449/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 8, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20220908143829/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 8, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20220908144400/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

sbueringer
sbueringer reviewed Sep 8, 2022
View reviewed changes
Comment thread tkg/kind/client_test.go Outdated
@randomvariable
Copy link
Copy Markdown
Contributor Author

randomvariable commented Sep 9, 2022 •
edited
Loading

looks like i've broken pinniped somewhere, will take a look

Update: Fixed

@randomvariable
Copy link
Copy Markdown
Contributor Author

randomvariable commented Sep 9, 2022 •
edited
Loading

Attempting to rebase on main breaks Tanzu Framework as packages have not been completely relocated.

Update: Added a commit with fixups

@randomvariable randomvariable force-pushed the capi-update branch 2 times, most recently from d2a97f3 to 0968b7c Compare September 9, 2022 11:07
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 9, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20220909111710/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 12, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20221012115926/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 12, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20221012115947/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable
Copy link
Copy Markdown
Contributor Author

randomvariable commented Oct 12, 2022

Changes made, and release note updated.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 12, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20221012133406/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable randomvariable requested review from a team October 12, 2022 14:29
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 12, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20221012144432/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 12, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20221012162303/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 12, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20221012171130/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 12, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20221012174223/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable randomvariable mentioned this pull request Oct 12, 2022
Open
Naadir Jeewa added 5 commits October 12, 2022 20:09
Update Cluster API and Providers for October 2022
ed6b1db 
Includes fixes for Kubernetes 1.24 and Cluster API Provider AWS

Signed-off-by: Naadir Jeewa <[email protected]>
goimport linter changes post CAPI update
0039806 
Signed-off-by: Naadir Jeewa <[email protected]>
api/providers/v1alpha1: Add storageversion to TemplateDefinition
f19fdd1 
Signed-off-by: Naadir Jeewa <[email protected]>
controller-gen manifest updates
12c6aab 
Signed-off-by: Naadir Jeewa <[email protected]>
config/.gitignore: Avoid duplicate files
e4ceaea 
due to kubernetes-sigs/controller-tools#663

Signed-off-by: Naadir Jeewa <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 12, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3157/20221012192410/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@vuil
Copy link
Copy Markdown
Contributor

vuil commented Oct 12, 2022 •
edited
Loading

LGTM, thanks for keeping logical commits and making it easier to review.
Trying to understand what happened with the Main/Build check.

@vuil
Copy link
Copy Markdown
Contributor

vuil commented Oct 12, 2022

Looks like some kind of runner OOS issue, retriggering now.

imikushin
imikushin approved these changes Oct 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@imikushin imikushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imikushin imikushin added the ok-to-merge PRs should be labelled with this before merging label Oct 12, 2022
@randomvariable randomvariable merged commit a070a5e into vmware-tanzu:main Oct 12, 2022
@randomvariable randomvariable deleted the capi-update branch October 12, 2022 23:25
@randomvariable randomvariable mentioned this pull request Oct 13, 2022
Open
@ykakarap ykakarap mentioned this pull request Oct 18, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@prkalle prkalle Awaiting requested review from prkalle

5 more reviewers

@marckhouzam marckhouzam marckhouzam left review comments

@sbueringer sbueringer sbueringer left review comments

@anujc25 anujc25 anujc25 left review comments

@imikushin imikushin imikushin approved these changes

@vuil vuil vuil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required ok-to-merge PRs should be labelled with this before merging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@randomvariable @sbueringer @alfredthenarwhal @vuil @marckhouzam @imikushin @anujc25 @vmwclabot