Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vmware/govmomi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.24.1
Choose a base ref
...
head repository: vmware/govmomi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.24.2
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Oct 14, 2021

  1. fix: avoid use of vNIC IP in guest.TransferURL if there are multiple 

    InitiateFileTransfer{To,From}Guest methods return an ESX host's inventory name (HostSystem.Name).
This name was used to add the host to vCenter and cannot be changed
(unless the host is removed from inventory and added back with another name).
The name used when adding to VC may not resolvable by this client's DNS, so we prefer an ESX management IP.
However, if there is more than one management vNIC, we don't know which IP(s) the client has a route to.
Leave the hostname as-is in that case or if the env var has disabled the preference.
    @dougm
    dougm committed Oct 14, 2021
    Copy the full SHA
    5a2a8ab View commit details

  2. fix: avoid vNIC mapping in guest.TransferURL if URL.Host is an IP 

    No need to map the guest transfer URL host to the ESX vNIC IP if the URL.Host is already an IP address.
In which case we can also avoid property collection of the vNIC config.
Using the original IP also a must when the ESXi host is dual stack, but the client has only pure IPv6.

Changed the host cache value from URL.Hostname() to URL.Host, so IP-literal form is maintained.
e.g. URL.Hostname() is "fe80::1" when URL.Host is "[fe80::1]:80"

Fixes #2553
    @dougm
    dougm committed Oct 14, 2021
    Copy the full SHA
    b18f06b View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff v0.24.1...v0.24.2