Skip to content

Commit feba2f0

Browse files
authored
[action] [PR:22600] [TACACS] Fix memory leak when authenticating using tacacs (sonic-net#1170)
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it A small memory leak was found when running TACACS ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it A patch was created for the libnss-tacplus repository that will fix the memory leak. #### How to verify it Configure TACACS Use the python script that reproduce the consumption and monitor its memory consumption. <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
1 parent 0ce8a8c commit feba2f0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/tacacs/nss/patch/series

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@
1010
0010-Send-remote-address-in-TACACS-authorization-message.patch
1111
0011-Replace-popen-shell-execution-with-safer-execle.patch
1212
0012-fix-compile-error-conditionals.patch
13+
0013-Partial-memleak-fix-due-to-unfreed-strdup.patch

0 commit comments

Comments
 (0)