[ModelRunner V2] Enable by default for all dense models#44443
Merged
Conversation
Signed-off-by: yewentao256 <[email protected]>
yewentao256
requested review from
ProExpertProg,
WoosukKwon,
hmellor,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth and
youkaichao
as code owners
June 3, 2026 19:25
yewentao256
added
ready
yewentao256
changed the title
43 tasks
Signed-off-by: yewentao256 <[email protected]>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: yewentao256 <[email protected]>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: yewentao256 <[email protected]>
njhill
requested review from
LucasWilkinson,
MatthewBonanni,
dllehr-amd and
tdoublep
as code owners
June 30, 2026 17:16
This comment was marked as resolved.
This comment was marked as resolved.
njhill
force-pushed
the
wentao-enable-all-dense-for-mrv2
branch
from
July 1, 2026 19:49
f1af290 to
cd249be
Compare
njhill
added
ready-run-all-tests
njhill
changed the title
njhill
approved these changes
Jul 2, 2026
njhill
left a comment
njhill
left a comment
Member
There was a problem hiding this comment.
Thanks @yewentao256, we've finally addressed all the gaps and got the full CI clean!
Member
|
(remaining two failures are known/unrelated) |
allenh1
pushed a commit
to allenh1/vllm
that referenced
this pull request
Jul 3, 2026
Sync 2026-07-03: picks up Model Runner V2 improvements (motivated by V2 viability reopening via PR#26). Notable: MRV2 scheduler req-slot bugfix (vllm-project#46974), MRV2 spec-decode int32 block-verify overflow fix (vllm-project#47383), MRV2 DSA-indexer prefill warmup for GLM-5.2/DSA (vllm-project#47285), V2-default for dense models (vllm-project#44443 — DSv4 is MoE so stays V1), DeepGEMM tag -> nv-dev a6b593d2 for SM120 (vllm-project#47304), TLI heterogeneous-vocab spec decode (vllm-project#38174), Delete PagedAttention (vllm-project#47361 — no impact, our sparse-MLA runner is a flashinfer symbol), Xqa decode kernels (vllm-project#43232). Conflict: vllm/v1/spec_decode/llm_base_proposer.py (our DSv4 MTP spec_step_idx routing vs upstream TLI) — resolved keeping BOTH: TLI's heterogeneous-vocab branch routed through our _compute_logits(spec_step_idx). Our SM12x stack preserved (persistent_topk, topk.cu, PR#26 padded-Q kernel, dspark, attention, R1 hardening all UNCHANGED); config/vllm.py DSv4->V1 default + DSpark env-control intact.
hmellor
added a commit
to hmellor/vllm
that referenced
this pull request
Jul 4, 2026
…ph capture OOM test_chatglm3_lora_tp4_fully_sharded_loras OOMs during FULL cudagraph capture on 4xL4 since ModelRunner V2 became the default for dense models (vllm-project#44443): without max_num_seqs the test captures graphs up to batch 512, and V2's larger KV cache allocation leaves too little headroom. Cap max_num_seqs at 16 like the sibling test_chatglm3_lora_tp4 so capture sizes stop at 32. The test only ever sends 3 prompts. Co-authored-by: Claude Signed-off-by: Harry Mellor <[email protected]>
4 tasks
jakki-amd
pushed a commit
to jakki-amd/vllm
that referenced
this pull request
Jul 6, 2026
…#44443) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Nick Hill <[email protected]> Co-authored-by: Nick Hill <[email protected]>
lkk12014402
pushed a commit
to lkk12014402/vllm
that referenced
this pull request
Jul 8, 2026
…#44443) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Nick Hill <[email protected]> Co-authored-by: Nick Hill <[email protected]>
mayuyuace
pushed a commit
to mayuyuace/vllm
that referenced
this pull request
Jul 9, 2026
…#44443) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Nick Hill <[email protected]> Co-authored-by: Nick Hill <[email protected]> Signed-off-by: mayuyuace <[email protected]>
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
…#44443) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Nick Hill <[email protected]> Co-authored-by: Nick Hill <[email protected]>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…#44443) Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Nick Hill <[email protected]> Co-authored-by: Nick Hill <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #41286
Test
Covered in CI