Skip to content

reasoning_content -> reasoning#27752

Merged
hmellor merged 8 commits intovllm-project:mainfrom
hmellor:reasoning
Nov 8, 2025
Merged

reasoning_content -> reasoning#27752
hmellor merged 8 commits intovllm-project:mainfrom
hmellor:reasoning

Conversation

@hmellor
Copy link
Copy Markdown
Member

@hmellor hmellor commented Oct 29, 2025 •
edited by github-actions bot
Loading

  • reasoning_content is only named this way for historical reasons (this is what deepseek originally used)
  • With the release of GPT-OSS, OpenAI provided guidance that reasoning content should be returned in reasoning for the Chat Completions API (even though there is no official spec for handling this in the published OpenAI specs)
  • This behaviour matches OpenRouter

@mergify
Copy link
Copy Markdown

mergify bot commented Oct 29, 2025

Documentation preview: https://vllm--27752.org.readthedocs.build/en/27752/

@mergify mergify bot added documentation Improvements or additions to documentation deepseek Related to DeepSeek models frontend qwen Related to Qwen models gpt-oss Related to GPT-OSS models structured-output labels Oct 29, 2025
@hmellor hmellor marked this pull request as ready for review October 29, 2025 15:59
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Oct 29, 2025
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@hmellor hmellor mentioned this pull request Oct 29, 2025
Closed
1 task
@hmellor hmellor mentioned this pull request Oct 30, 2025
Closed
@github-project-automation github-project-automation bot moved this from To Triage to Ready in gpt-oss Issues & Enhancements Nov 5, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 5, 2025 01:55
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 5, 2025
@mergify
Copy link
Copy Markdown

mergify bot commented Nov 5, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 5, 2025
@xiaoxiangmoe
Copy link
Copy Markdown

xiaoxiangmoe commented Nov 5, 2025

Maybe also add reasoning_details?

@hmellor
Copy link
Copy Markdown
Member Author

hmellor commented Nov 5, 2025 •
edited
Loading

Thanks for the suggestion! reasoning_details actually contains different information to reasoning, so it's not really in scope for this PR.

If there is enough interest in the reasoning_details field then we could add support for it in a future PR.

@mergify mergify bot removed the needs-rebase label Nov 5, 2025
@hmellor hmellor enabled auto-merge (squash) November 8, 2025 02:40
@hmellor hmellor merged commit d9ab1ad into vllm-project:main Nov 8, 2025
49 checks passed
@hmellor hmellor deleted the reasoning branch November 8, 2025 12:15
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
@hmellor @devpatelio
reasoning_content -> reasoning (vllm-project#27752)
242358b 
Signed-off-by: Harry Mellor <[email protected]>
rabi added a commit to rabi/goose that referenced this pull request Feb 18, 2026
@rabi
fix(openai): support "reasoning" field alias in streaming deltas
b2eaf18 
Add serde alias so both "reasoning" (vLLM, see vllm-project/vllm#27752)
and "reasoning_content" (DeepSeek, SGLang) are recognized in streaming
deltas. Once "reasoning" becomes the standard, it should become the
primary field name.

Change-Id: Ie24a7624903e9243c470783b0f482e2cdbf8b26c
Signed-off-by: rabi <[email protected]>
@rabi rabi mentioned this pull request Feb 18, 2026
Merged
9 tasks
@0xbe7a 0xbe7a mentioned this pull request Mar 9, 2026
Merged
@ZhongsJie ZhongsJie mentioned this pull request Mar 12, 2026
Closed
1 task
@delta9000 delta9000 mentioned this pull request Mar 29, 2026
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaunceyjiang chaunceyjiang chaunceyjiang left review comments

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@patrickvonplaten patrickvonplaten Awaiting requested review from patrickvonplaten

@mgoin mgoin Awaiting requested review from mgoin

@russellb russellb Awaiting requested review from russellb russellb is a code owner

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo

@NickLucche NickLucche Awaiting requested review from NickLucche NickLucche is a code owner

Assignees

No one assigned

Labels

deepseek Related to DeepSeek models documentation Improvements or additions to documentation frontend gpt-oss Related to GPT-OSS models qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed structured-output tool-calling v1

Projects

Structured Output
Status: Done
Tool Calling
Status: Done
gpt-oss Issues & Enhancements
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hmellor @xiaoxiangmoe @chaunceyjiang @DarkLight1337