Skip to content

[Bugfix] Fix benchmark_moe.py #19016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ywang96 merged 4 commits into from
Jun 10, 2025
Merged

[Bugfix] Fix benchmark_moe.py #19016

ywang96 merged 4 commits into from
Jun 10, 2025

Conversation

@gty111
Copy link
Contributor

@gty111 gty111 commented Jun 2, 2025 •
edited by github-actions bot
Loading

Fix some errors in benchmark_moe.py

  • Replace List to list to solve NameError: name 'List' is not defined. Did you mean: 'list'?
  • Remove SimpleNamespace to solve TypeError: types.SimpleNamespace() argument after ** must be a mapping, not Qwen3MoeConfig

image

@houseroad

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@gty111 gty111 force-pushed the patch-1 branch 2 times, most recently from 8a8e0ca to e547a06 Compare June 3, 2025 02:32
gty111 added 2 commits June 3, 2025 10:37
houseroad
houseroad reviewed Jun 7, 2025
View reviewed changes
@gty111
Update benchmark_moe.py
b643d78 
Signed-off-by: Tianyu Guo <[email protected]>
@gty111
Using list instead of List
e3b623d 
Signed-off-by: Tianyu Guo <[email protected]>
@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 9, 2025
@yewentao256 yewentao256 mentioned this pull request Jun 10, 2025
Closed
@ywang96 ywang96 merged commit 4589b94 into vllm-project:main Jun 10, 2025
53 checks passed
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jun 10, 2025

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad left review comments

@yewentao256 yewentao256 yewentao256 approved these changes

@ywang96 ywang96 ywang96 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gty111 @houseroad @yewentao256 @ywang96