Fix overflow in awq kernel#1295
Merged
Merged
Conversation
Contributor
|
Thank you so much for this fix! This will enable other long-context models to be more easily implemented. @WoosukKwon @zhuohan123 Let's get this merged soon! |
WoosukKwon
self-requested a review
October 10, 2023 16:58
WoosukKwon
reviewed
Oct 10, 2023
WoosukKwon
left a comment
WoosukKwon
left a comment
Collaborator
There was a problem hiding this comment.
@chu-tianxiang Thanks for the fix! Left a small question. Please check it out!
WoosukKwon
approved these changes
Oct 11, 2023
WoosukKwon
left a comment
WoosukKwon
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks again for fixing the bug!
s4rduk4r
added a commit
to s4rduk4r/AutoAWQ
that referenced
this pull request
Nov 22, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Co-authored-by: 楚天翔 <[email protected]>
pi314ever
pushed a commit
to pi314ever/vllm
that referenced
this pull request
May 22, 2025
…del. (vllm-project#1295) the issue as the PR descripted HabanaAI/vllm-hpu-extension#184, and have merged in vllm-hpu-extension repo side, so I update the commit to use it. Signed-off-by: changwangss <[email protected]>
WeNeedMoreCode
pushed a commit
to WeNeedMoreCode/vllm
that referenced
this pull request
Dec 15, 2025
### What this PR does / why we need it? Add sleep related doc and example --------- Signed-off-by: wangli <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix overflow problem in #1236.
For Mistral model, the output dimension of gate_up_proj is
14336 * 2 = 28672and maximum blockIdx_z is7, so when a length over2147483647 / 7 / 28672 = 10699would cause overflow. (Considering the padding in vllm, the maximum is actually10699 // 8 * 8 + 1 = 10697)