Use modules list for sequential epoch end by zeel2104 · Pull Request #2682 · vllm-project/llm-compressor

zeel2104 · 2026-05-02T11:47:16Z

SUMMARY:
Changed LifecycleCallbacks.sequential_epoch_end to pass a list of modules instead of the full subgraph. The sequential pipeline now derives the module list from each subgraph, and AutoRound consumes that list directly.

TEST PLAN:
Ran focused lifecycle and sequential pipeline tests locally with Python 3.12:

python -m pytest tests\llmcompressor\core\test_session_functions.py
python -m pytest tests\llmcompressor\pipelines\sequential\test_helpers.py tests\llmcompressor\core\test_session_functions.py

Result: 10 passed.

github-actions · 2026-05-02T11:47:26Z

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

coderabbitai · 2026-05-02T11:47:28Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c6e2e4a9-a027-407c-b51b-0f363380516c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Walkthrough

The PR updates LifecycleCallbacks.sequential_epoch_end to accept a concrete list of Module objects instead of a Subgraph object. The change propagates through AutoRound's apply_autoround method and the sequential pipeline caller, which now extracts and passes module lists directly to the callback.

Changes

Sequential Epoch End API Refactor

Layer / File(s)	Summary
Type Imports `src/llmcompressor/core/session_functions.py`	Import changed from `llmcompressor.pipelines.sequential.Subgraph` to `torch.nn.Module` under `TYPE_CHECKING` to support the updated callback signature.
Core API Definition `src/llmcompressor/core/session_functions.py`	`LifecycleCallbacks.sequential_epoch_end` signature updated from `subgraph: "Subgraph"` to `modules: list["Module"]`; event payload now passes `modules=modules` instead of `subgraph=subgraph`.
AutoRound Consumer `src/llmcompressor/modifiers/autoround/base.py`	`on_event` handler extracts `modules` from kwargs and passes to `apply_autoround`; `apply_autoround` filters the modules list directly via `_is_decoding_layer` instead of deriving from `subgraph.submodules()`.
Pipeline Wiring `src/llmcompressor/pipelines/sequential/pipeline.py`	Call to `LifecycleCallbacks.sequential_epoch_end` now passes `list(subgraph.submodules(model))` instead of the `subgraph` object itself.
Tests / Verification `tests/llmcompressor/core/test_session_functions.py`	New test `test_sequential_epoch_end_passes_modules` validates that the callback correctly propagates the modules list and additional kwargs to the emitted event.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

Update Lifecycle.sequential_epoch_end to use a list of modules instead of a subgraph #2666: This PR directly implements the requested API change to pass a list of modules instead of a subgraph object to sequential_epoch_end.

Suggested labels

refactor, autoround, two-reviews

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 62.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Use modules list for sequential epoch end' clearly and concisely describes the main change: replacing subgraph parameter with a modules list in the sequential epoch end callback.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description clearly relates to the changeset, explaining the API change from subgraph to modules list across multiple files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

mergify · 2026-05-02T11:47:55Z

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Require two reviews

Wonderful, this rule succeeded.

PRs labelled "two-reviews" must have at least two approving reviews before merging.

#approved-reviews-by >= 2
#changes-requested-reviews-by = 0

zeel2104 · 2026-05-02T11:51:48Z

/ready

gemini-code-assist

Code Review

This pull request refactors the sequential_epoch_end lifecycle event to pass a list of modules instead of a Subgraph object, updating LifecycleCallbacks, the AutoRound modifier, and the sequential pipeline accordingly. A new test verifies the updated event signature. Feedback was provided to replace a runtime assert with an explicit ValueError in the AutoRound modifier to prevent validation from being bypassed in optimized Python environments.

zeel2104 · 2026-05-02T11:54:17Z

/ready

zeel2104 · 2026-05-02T11:55:14Z

Local testing passed. Could a maintainer please add the ready label as I do not have permissions?

brian-dellabetta

thanks for the contribution, these changes look good to me.

edit: can you run make style / make quality?

mergify · 2026-05-04T16:27:56Z

The quality checks have failed. Please run make style and make quality under
the root directory to adddress the lint failures. You will need to install the
dev optional install to get the required linting packages:
https://github.com/vllm-project/llm-compressor/blob/main/CONTRIBUTING.md

HDCharles · 2026-05-04T16:59:06Z

fix quality

HDCharles · 2026-05-04T17:00:30Z

looks good but needs to pass CI, fix quality issue and then this is ready to land, great work!

…h-end-modules

zeel2104 · 2026-05-04T20:12:46Z

Updated the branch with latest upstream main and reran local checks:

..venv312\Scripts\ruff.exe check --no-cache src tests examples setup.py
..venv312\Scripts\ruff.exe format --check --no-cache src tests examples setup.py
..venv312\Scripts\python.exe -m pytest tests\llmcompressor\pipelines\sequential\test_helpers.py tests\llmcompressor\core\test_session_functions.py

Ruff checks passed.

Use modules list for sequential epoch end

6fea087

mergify Bot added the two-reviews When a PR requires two reviews label May 2, 2026

coderabbitai Bot added autoround For any PR / issue related to autoround support Refactor Code cleanup and/or improvements to existing features labels May 2, 2026

gemini-code-assist Bot reviewed May 2, 2026

View reviewed changes

Comment thread src/llmcompressor/modifiers/autoround/base.py Outdated

Use explicit error for AutoRound layer validation

ebcfedf

brian-dellabetta approved these changes May 4, 2026

View reviewed changes

brian-dellabetta requested review from HDCharles and kylesayrs May 4, 2026 16:24

brian-dellabetta added the ready When a PR is ready for review label May 4, 2026

Merge branch 'main' into fix/sequential-epoch-end-modules

768ec5d

mergify Bot added the quality-failed label May 4, 2026

HDCharles approved these changes May 4, 2026

View reviewed changes

Apply ruff formatting

016a7cc

mergify Bot removed the quality-failed label May 4, 2026

Merge remote-tracking branch 'upstream/main' into fix/sequential-epoc…

861db1c

…h-end-modules

Merge branch 'main' into fix/sequential-epoch-end-modules

b8dc740

brian-dellabetta enabled auto-merge (squash) May 4, 2026 20:20

brian-dellabetta merged commit 284401a into vllm-project:main May 4, 2026
12 of 13 checks passed

Conversation

zeel2104 commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 2, 2026

Uh oh!

coderabbitai Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Suggested labels

❌ Failed checks (1 warning)

Uh oh!

mergify Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Protections

🟢 Require two reviews

Uh oh!

zeel2104 commented May 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

zeel2104 commented May 2, 2026

Uh oh!

zeel2104 commented May 2, 2026

Uh oh!

brian-dellabetta left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented May 4, 2026

Uh oh!

HDCharles commented May 4, 2026

Uh oh!

HDCharles commented May 4, 2026

Uh oh!

zeel2104 commented May 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zeel2104 commented May 2, 2026 •

edited

Loading

coderabbitai Bot commented May 2, 2026 •

edited

Loading

mergify Bot commented May 2, 2026 •

edited

Loading

brian-dellabetta left a comment •

edited

Loading