fix(expect): soft assertions continue after .resolves/.rejects promise errors by mixelburg · Pull Request #9843 · vitest-dev/vitest

mixelburg · 2026-03-10T22:18:01Z

Bug

When expect.soft() is combined with .resolves and the awaited promise rejects, the test aborts instead of recording the failure and continuing (which is what expect.soft is designed to do).

The symmetric case also fails: expect.soft(resolvedPromise).rejects aborts when the promise resolves.

Fixes #9838

Root cause

Inside both the .resolves and .rejects proxy accessors, the method interceptor creates a new promise (the Promise.resolve(obj).then(...).catch(...) chain), then hands it to recordAsyncExpect:

return recordAsyncExpect(
  test,
  promise,
  createAssertionMessage(utils, this, !!args.length),
  error,
  // <-- isSoft was never passed!
)

recordAsyncExpect has a special isSoft branch:

if (isSoft) {
  promise = promise.then(noop, (err) => {
    handleTestError(test, err)  // record without throwing
  })
}

Without isSoft, the rejection propagates through the returned promise wrapper; when the caller awaits it, the test runner sees an unhandled rejection and aborts the test.

Fix

Pass utils.flag(this, 'soft') (which is already set by expect.soft()) as the fifth argument in both recordAsyncExpect calls.

Tests added

Added two new fixture test cases to test/cli/fixtures/expect-soft/expects/soft.test.ts:

promise rejection — two consecutive expect.soft(rejectedPromise).resolves.toBe(...) assertions; both should execute and both failures should be reported (regression for issue)
promise resolved instead of rejecting — two consecutive expect.soft(resolvedPromise).rejects.toBe(...) assertions; same expectation for symmetric case

And corresponding expectations in test/cli/test/expect-soft.test.ts that verify both failure messages appear in stderr.

…s proxies When expect.soft() is used with .resolves, a rejection in the awaited promise was not handled softly. Instead of recording the failure and continuing (as expect.soft() should), the rejection propagated to the test, aborting execution of subsequent assertions. Root cause: the .resolves and .rejects proxy callbacks call recordAsyncExpect() without passing the isSoft flag. When isSoft is false/undefined, recordAsyncExpect does not attach a rejection handler to swallow the error and record it in test.result.errors; the returned promise still rejects, so awaiting it terminates the test. Fix: pass utils.flag(this, 'soft') as the isSoft argument to both recordAsyncExpect calls (in the resolves proxy and in the rejects proxy). The same fix also corrects the symmetric case for .rejects: if expect.soft(resolvedPromise).rejects is used, the 'resolved instead of rejecting' error is now recorded softly and execution continues. Fixes vitest-dev#9838

hi-ogawa · 2026-03-11T00:33:26Z

CI failing. fix please.

Co-Authored-By: Claude Opus 4.6 <[email protected]>

netlify · 2026-03-12T09:31:20Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`cd2692f`
🔍 Latest deploy log	https://app.netlify.com/projects/vitest-dev/deploys/69b777061f32c50008d16c62
😎 Deploy Preview	https://deploy-preview-9843--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa · 2026-03-13T00:54:28Z

Looks good. Can you also add another already working case as test cases? #9838

hi-ogawa

It turned out what I requested is already covered in

vitest/test/cli/fixtures/expect-soft/expects/soft.test.ts

Lines 43 to 58 in 8fc9cff

    
           test('promise', async () => { 
        
             await expect.soft( 
        
               new Promise((resolve) => { 
        
                 setTimeout(() => { 
        
                   resolve(1) 
        
                 }) 
        
               }), 
        
             ).resolves.toBe(2) 
        
             await expect.soft( 
        
               new Promise((resolve) => { 
        
                 setTimeout(() => { 
        
                   resolve(2) 
        
                 }) 
        
               }), 
        
             ).resolves.toBe(3) 
        
           })

fix: correct expected error message format in soft expect rejects test

8fc9cff

Co-Authored-By: Claude Opus 4.6 <[email protected]>

hi-ogawa assigned hi-ogawa and unassigned hi-ogawa Mar 13, 2026

hi-ogawa approved these changes Mar 16, 2026

View reviewed changes

Merge branch 'main' into fix/soft-expect-resolves-rejects

cd2692f

hi-ogawa merged commit 6d74b49 into vitest-dev:main Mar 16, 2026
15 of 16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(expect): soft assertions continue after .resolves/.rejects promise errors#9843

fix(expect): soft assertions continue after .resolves/.rejects promise errors#9843
hi-ogawa merged 3 commits intovitest-dev:mainfrom
mixelburg:fix/soft-expect-resolves-rejects

mixelburg commented Mar 10, 2026

Uh oh!

hi-ogawa commented Mar 11, 2026

Uh oh!

netlify bot commented Mar 12, 2026 •

edited

Loading

Uh oh!

hi-ogawa commented Mar 13, 2026

Uh oh!

hi-ogawa left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	test('promise', async () => {
	await expect.soft(
	new Promise((resolve) => {
	setTimeout(() => {
	resolve(1)
	})
	}),
	).resolves.toBe(2)
	await expect.soft(
	new Promise((resolve) => {
	setTimeout(() => {
	resolve(2)
	})
	}),
	).resolves.toBe(3)
	})

Uh oh!

Conversation

mixelburg commented Mar 10, 2026

Bug

Root cause

Fix

Tests added

Uh oh!

hi-ogawa commented Mar 11, 2026

Uh oh!

netlify bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vitest-dev ready!

Uh oh!

hi-ogawa commented Mar 13, 2026

Uh oh!

hi-ogawa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Mar 12, 2026 •

edited

Loading