fix: ensure sequential mock/unmock resolution by hi-ogawa · Pull Request #9830 · vitest-dev/vitest

hi-ogawa · 2026-03-09T10:44:32Z

Description

Resolves https://discord.com/channels/804011606160703521/1480463846253662218/1480481214170402993

Using Promise.all for handling mock and unmock in parallel can cause race condition when multiple mock and unmock of same modules are involved.

The above CI failures is related because it goes through

"first import"
- beforeEach -> doMock
- test -> import
- afterEach -> doUnmock
"second import"
- beforeEach -> doMock
- test -> import
  - 👈 At this step, unmock/mock requests are handled in parallel. If doUnmock processed slower, then module doesn't get mocked and thus module not found.

vitest/test/core/test/unmock-import.test.ts

Lines 4 to 27 in 4107f8e

    
           beforeEach(() => { 
        
             vi.doMock('/data', () => ({ 
        
               data: { 
        
                 state: 'STARTED', 
        
               }, 
        
             })) 
        
           }) 
        
           afterEach(() => { 
        
             vi.doUnmock('/data') 
        
           }) 
        
           test('first import', async () => { 
        
             // @ts-expect-error I know this 
        
             const { data } = await import('/data') 
        
             data.state = 'STOPPED' 
        
             expect(data.state).toBe('STOPPED') 
        
           }) 
        
           test('second import should have been re-mocked', async () => { 
        
             // @ts-expect-error I know this 
        
             const { data } = await import('/data') 
        
             expect(data.state).toBe('STARTED') 
        
           })

  ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
   FAIL   threads  test/unmock-import.test.ts:23:1 > second import should have been re-mocked
  Error: Cannot find module '/data'
   ❯ test/unmock-import.test.ts:25:20
       23| test('second import should have been re-mocked', async () => {
       24|   // @ts-expect-error I know this
       25|   const { data } = await import('/data')
         |                    ^
       26|   expect(data.state).toBe('STARTED')
       27| })
  ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

sheremet-va · 2026-03-10T08:44:19Z

Could we still have it in parallel if all of them are of the same type? (mock/unmock) I feel like this can hit performance hard otherwise.

netlify · 2026-03-10T10:16:09Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`c28db7d`
🔍 Latest deploy log	https://app.netlify.com/projects/vitest-dev/deploys/69c206802a4f1a0008f4bc71
😎 Deploy Preview	https://deploy-preview-9830--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa · 2026-03-10T10:17:43Z

That optimization should work fine. Just Claude pushed weird code, so don't look that yet 🙃

Resolve mock/unmock operations in parallel when all pending operations are of the same type. Fall back to sequential resolution when there's a mix to preserve ordering correctness. Co-Authored-By: Claude Opus 4.6 <[email protected]>

…lution

packages/vitest/src/runtime/moduleRunner/bareModuleMocker.ts

…lution Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

… sequential Group consecutive pending mocks by action type (mock/unmock) and resolve each group in parallel, while running groups sequentially. This avoids unnecessarily serializing all resolutions when a single unmock appears among many mocks. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

hi-ogawa added 3 commits March 9, 2026 19:19

fix: ensure sequential mock/unmock resolution

5c6ea68

test: add repro

4107f8e

chore: lint

120e9a7

hi-ogawa marked this pull request as ready for review March 9, 2026 13:44

hi-ogawa mentioned this pull request Mar 10, 2026

soft doesn't work for expect.soft(rejection).resolves #9838

Closed

6 tasks

hi-ogawa force-pushed the 03-09-fix_ensure_sequential_mock_unmock_resolution branch from 253625b to ff15658 Compare March 10, 2026 10:28

hi-ogawa added 3 commits March 10, 2026 19:32

refactor: cleanup

739ff08

Merge branch 'main' into 03-09-fix_ensure_sequential_mock_unmock_reso…

2fbff0b

…lution

Merge branch 'main' into 03-09-fix_ensure_sequential_mock_unmock_reso…

de1a665

…lution

hi-ogawa requested a review from sheremet-va March 11, 2026 01:40

sheremet-va requested changes Mar 19, 2026

View reviewed changes

packages/vitest/src/runtime/moduleRunner/bareModuleMocker.ts Outdated Show resolved Hide resolved

hi-ogawa and others added 3 commits March 24, 2026 12:31

Merge branch 'main' into 03-09-fix_ensure_sequential_mock_unmock_reso…

ac29cf7

…lution Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

refactor: nit

e3d8cfe

sheremet-va approved these changes Mar 24, 2026

View reviewed changes

sheremet-va merged commit 7c06598 into vitest-dev:main Mar 24, 2026
13 of 16 checks passed

hi-ogawa deleted the 03-09-fix_ensure_sequential_mock_unmock_resolution branch March 24, 2026 08:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: ensure sequential mock/unmock resolution#9830

fix: ensure sequential mock/unmock resolution#9830
sheremet-va merged 10 commits intovitest-dev:mainfrom
hi-ogawa:03-09-fix_ensure_sequential_mock_unmock_resolution

hi-ogawa commented Mar 9, 2026 •

edited

Loading

Uh oh!

sheremet-va commented Mar 10, 2026

Uh oh!

netlify bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

hi-ogawa commented Mar 10, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	beforeEach(() => {
	vi.doMock('/data', () => ({
	data: {
	state: 'STARTED',
	},
	}))
	})

	afterEach(() => {
	vi.doUnmock('/data')
	})

	test('first import', async () => {
	// @ts-expect-error I know this
	const { data } = await import('/data')
	data.state = 'STOPPED'
	expect(data.state).toBe('STOPPED')
	})

	test('second import should have been re-mocked', async () => {
	// @ts-expect-error I know this
	const { data } = await import('/data')
	expect(data.state).toBe('STARTED')
	})

Uh oh!

Conversation

hi-ogawa commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

sheremet-va commented Mar 10, 2026

Uh oh!

netlify bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vitest-dev ready!

Uh oh!

hi-ogawa commented Mar 10, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hi-ogawa commented Mar 9, 2026 •

edited

Loading

netlify bot commented Mar 10, 2026 •

edited

Loading