Use meta.url as the argument to createRequire() when loading a module#9310
Closed
penalosa wants to merge 1 commit intovitest-dev:mainfrom
Closed
Use meta.url as the argument to createRequire() when loading a module#9310penalosa wants to merge 1 commit intovitest-dev:mainfrom
meta.url as the argument to createRequire() when loading a module#9310penalosa wants to merge 1 commit intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sheremet-va
approved these changes
Dec 20, 2025
Member
|
This seems to break some tests. I don't think the |
| // \x00 is a rollup convention for virtual files, | ||
| // it is not allowed in actual file names | ||
| if (filename[0] === '\x00' || !isAbsolute(filename)) { | ||
| if ((filename[0] === '\x00' || !isAbsolute(filename))) { |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When creating a
require()function usingcreateRequire(), pass in the URL rather than the filename. Passing in the filename can cause bugs on Windows, and error messages along the lines ofTypeError: The argument 'path' The argument must be a file URL object, a file URL string, or an absolute path string..This matches the implementation in
vite-node: https://github.com/antfu-collective/vite-node/blob/63e2a8111cb674335823746a5df87eae666eee76/src/client.ts#L550Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.