fix: correctly remove undefined values in options#8487
Closed
TrevorBurnham wants to merge 1 commit intovitest-dev:mainfrom
Closed
fix: correctly remove undefined values in options#8487TrevorBurnham wants to merge 1 commit intovitest-dev:mainfrom
TrevorBurnham wants to merge 1 commit intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
This is really funny, let's just remove the call altogether to keep the current behavior. |
6 tasks
Contributor
Author
Roger that! Closing in favor of #8501. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This
removeUndefinedValuesutility function was added by #2281. However, there's a bug in the implementation: It performs aninloop over the array returned byObject.keys, which means that it iterates over the array indices1, 2, 3...instead of the actual object keys. That makes it effectively a no-op.Since no one has noticed this in 3 years, simply removing the function would be one option. It's not clear to me why the
TypeErrordescribed in #2153 occurred. However, this PR goes with the other option: Implementing the intended behavior by removing theObject.keysso thatiniterates over the object's keys.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.