fix(expect): handle async errors in expect.soft#8145
Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom Jun 11, 2025
Merged
fix(expect): handle async errors in expect.soft#8145sheremet-va merged 2 commits intovitest-dev:mainfrom
sheremet-va merged 2 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sheremet-va
requested changes
Jun 11, 2025
Member
sheremet-va
left a comment
sheremet-va
left a comment
There was a problem hiding this comment.
Looks very good, thank you! Just one little thing
packages/expect/src/utils.ts
Outdated
| return fn.apply(this, args) | ||
| const result = fn.apply(this, args) | ||
|
|
||
| if (result && typeof result === 'object' && result instanceof Promise) { |
Member
There was a problem hiding this comment.
I thought I already fixed that, but maybe I forgot. Can you change the check from instanceof Promise to typeof result.then === 'function' here and in jest-extend.ts?
And use then(noop, (err) => { /* ... */ }) here instead
This is needed to support PromiseLike (we already do this in all other places except here)
Contributor
Author
There was a problem hiding this comment.
The updates have been submitted. Thank you for your suggestion!
sheremet-va
approved these changes
Jun 11, 2025
Member
|
LGTM! Thank you! |
This was referenced Jul 7, 2025
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8092
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.