Skip to content

Comments

fix(expect): unbundle @types/chai#7937

Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom
hi-ogawa:fix-unbundle-chai-types
May 6, 2025
Merged

fix(expect): unbundle @types/chai#7937
sheremet-va merged 2 commits intovitest-dev:mainfrom
hi-ogawa:fix-unbundle-chai-types

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented May 6, 2025 •
edited
Loading

Description

Though I'm not sure having @types package in dependencies, I think unbundling should have the same effect as what we have now at least for pure vitest users. If users have an different @types/chai version somewhere, they are already broken anyways, so this change should only save more valid cases.

I confirmed the repro with pr package in https://github.com/hi-ogawa/reproductions/tree/main/vitest-4688-chai-types

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 6, 2025

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7937

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7937

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7937

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7937

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7937

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7937

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7937

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7937

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7937

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7937

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7937

vite-node

npm i https://pkg.pr.new/vite-node@7937

vitest

npm i https://pkg.pr.new/vitest@7937

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7937

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7937

commit: bb5a521

@netlify
Copy link

netlify bot commented May 6, 2025

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bb5a521
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/68195895736b7b0008862e73
😎 Deploy Preview https://deploy-preview-7937--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa mentioned this pull request May 6, 2025
Closed
6 tasks
@hi-ogawa hi-ogawa marked this pull request as ready for review May 6, 2025 00:59
@sheremet-va sheremet-va merged commit 525f524 into vitest-dev:main May 6, 2025
14 of 15 checks passed
@hi-ogawa hi-ogawa deleted the fix-unbundle-chai-types branch May 6, 2025 23:44
@kasperpeulen kasperpeulen mentioned this pull request May 9, 2025
Closed
@hi-ogawa hi-ogawa mentioned this pull request Jun 3, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

cr-tracked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@types/chai conflict with @vitest/expect/dist/chai.d.cts

2 participants

@hi-ogawa @sheremet-va