Skip to content

Comments

fix(coverage): await profiler calls#7763

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
AriPerkkio:fix/v8-coverage-wait-session-calls
Apr 4, 2025
Merged

fix(coverage): await profiler calls#7763
sheremet-va merged 1 commit intovitest-dev:mainfrom
AriPerkkio:fix/v8-coverage-wait-session-calls

Conversation

@AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Mar 29, 2025 •
edited
Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 29, 2025 •
edited
Loading

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7763

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7763

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7763

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7763

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7763

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7763

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7763

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7763

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7763

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7763

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7763

vite-node

npm i https://pkg.pr.new/vite-node@7763

vitest

npm i https://pkg.pr.new/vitest@7763

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7763

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7763

commit: 76a7b4d

@netlify
Copy link

netlify bot commented Mar 29, 2025 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit daae671
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67efa0098be7d30008dd6610
😎 Deploy Preview https://deploy-preview-7763--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio AriPerkkio mentioned this pull request Mar 29, 2025
Closed
6 tasks
@AriPerkkio AriPerkkio force-pushed the fix/v8-coverage-wait-session-calls branch from 48dee0b to daae671 Compare April 4, 2025 09:01
@AriPerkkio AriPerkkio force-pushed the fix/v8-coverage-wait-session-calls branch from daae671 to 76a7b4d Compare April 4, 2025 09:13
@AriPerkkio AriPerkkio marked this pull request as ready for review April 4, 2025 09:17
@AriPerkkio
Copy link
Member Author

AriPerkkio commented Apr 4, 2025 •
edited
Loading

We can merge this fix now and wait for Deno to fix the ScriptCoverage url issue on their side.

@sheremet-va
Copy link
Member

sheremet-va commented Apr 4, 2025

We can merge this fix now and wait for Deno to fix the ScriptCoverage url issue on their side.

Judging from the comment in the PR, doesn't seem like they will 😄

@sheremet-va sheremet-va merged commit 795a643 into vitest-dev:main Apr 4, 2025
12 of 14 checks passed
@AriPerkkio AriPerkkio deleted the fix/v8-coverage-wait-session-calls branch April 4, 2025 10:59
schogges pushed a commit to kumahq/kuma-gui that referenced this pull request Apr 23, 2025
@dependabot
chore(deps-dev): Bump vitest from 3.1.1 to 3.1.2 (#3781)
ecaab5d 
v3.1.2
   🐞 Bug Fixes
Add global chai variable in vitest/globals (fix: #7474)  -  by @​Jay-Karia in vitest-dev/vitest#7771 and vitest-dev/vitest#7474 (d9297)
Prevent modifying test.exclude when same object passed in coverage.exclude  -  by @​AriPerkkio in vitest-dev/vitest#7774 (c3751)
Fix already hoisted mock  -  by @​hi-ogawa in vitest-dev/vitest#7815 (773b1)
Fix test.scoped inheritance  -  by @​hi-ogawa in vitest-dev/vitest#7814 (db6c3)
Remove pointer-events-none after resizing the left panel  -  by @​alexprudhomme in vitest-dev/vitest#7811 (a7e77)
Default to run mode when stdin is not a TTY  -  by @​kentonv, @​hi-ogawa and @​sheremet-va in vitest-dev/vitest#7673 (6358f)
Use happy-dom/jsdom types for envionmentOptions  -  by @​hi-ogawa in vitest-dev/vitest#7795 (67430)
browser:
Fix transform error before browser server initialization  -  by @​hi-ogawa in vitest-dev/vitest#7783 (5f762)
Fix mocking from outside of root  -  by @​hi-ogawa in vitest-dev/vitest#7789 (03f55)
Scale iframe for non ui case  -  by @​hi-ogawa in vitest-dev/vitest#6512 (c3374)
coverage:
await profiler calls  -  by @​AriPerkkio in vitest-dev/vitest#7763 (795a6)
Expose profiling timers  -  by @​AriPerkkio in vitest-dev/vitest#7820 (5652b)
deps:
Update all non-major dependencies  -  in vitest-dev/vitest#7765 (7c3df)
Update all non-major dependencies  -  in vitest-dev/vitest#7831 (15701)
runner:
Correctly call test hooks and teardown functions  -  by @​sheremet-va in vitest-dev/vitest#7775 (3c00c)
Show stacktrace on test timeout error  -  by @​hi-ogawa in vitest-dev/vitest#7799 (df33b)
ui:
Load panel sizes from storage on initial load  -  by @​userquin in vitest-dev/vitest#7265 (6555d)
vite-node:
Named export should overwrite export all  -  by @​hi-ogawa in vitest-dev/vitest#7846 (5ba0d)
Add ERR_MODULE_NOT_FOUND code error if module cannot be loaded  -  by @​sheremet-va in vitest-dev/vitest#7776 (f9eac)
   🏎 Performance
browser: Improve browser parallelisation  -  by @​sheremet-va in vitest-dev/vitest#7665 (816a5)
This was referenced Apr 30, 2025
Open
Merged
@renovate renovate bot mentioned this pull request May 10, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request Jun 17, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

@hi-ogawa hi-ogawa Awaiting requested review from hi-ogawa

Assignees

No one assigned

Labels

cr-tracked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AriPerkkio @sheremet-va