Skip to content

Comments

fix: fix vm tests flakiness#7741

Merged
sheremet-va merged 6 commits intovitest-dev:mainfrom
sheremet-va:refactor/use-context-on-synthetic-module
Mar 26, 2025
Merged

fix: fix vm tests flakiness#7741
sheremet-va merged 6 commits intovitest-dev:mainfrom
sheremet-va:refactor/use-context-on-synthetic-module

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Mar 26, 2025 •
edited
Loading

Description

Vitest did not properly cache synthetic modules. After adding the cache, flakiness disappears. I wasn't able to reproduce this with a simple setup, unfortunately, so I am still not sure what exactly caused the crashes to happen.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

sheremet-va
sheremet-va commented Mar 26, 2025
View reviewed changes
@netlify
Copy link

netlify bot commented Mar 26, 2025

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 5ed3040
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67e3e5cf89c46a00087eb535
😎 Deploy Preview https://deploy-preview-7741--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va changed the title refactor: use context instead of return value in synthetic module callback fix: use context instead of return value in synthetic module callback Mar 26, 2025
@sheremet-va sheremet-va changed the title fix: use context instead of return value in synthetic module callback fix: fix vm tests flakiness Mar 26, 2025
AriPerkkio
AriPerkkio reviewed Mar 26, 2025
View reviewed changes
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Can we include these tests too now:

vitest/test/cli/test/stacktraces.test.ts

Line 95 in 12762ea

it.runIf(major < 22)('stacktrace in vmThreads', async () => {

vitest/test/cli/test/vm-threads.test.ts

Lines 5 to 7 in 12762ea

const [major] = process.version.slice(1).split('.').map(num => Number(num))
test.runIf(major < 22)('importing files in restricted fs works correctly', async () => {

vitest/test/cli/test/setup-files.test.ts

Lines 5 to 7 in 12762ea

const [major] = process.version.slice(1).split('.').map(num => Number(num))
test.each(['threads', 'vmThreads'])('%s: print stdout and stderr correctly when called in the setup file', async (pool) => {

@sheremet-va
Copy link
Member Author

sheremet-va commented Mar 26, 2025

Can we include these tests too now:

For sure!

AriPerkkio
AriPerkkio previously approved these changes Mar 26, 2025
View reviewed changes
sheremet-va
sheremet-va commented Mar 26, 2025
View reviewed changes
@sheremet-va sheremet-va merged commit 2702cf4 into vitest-dev:main Mar 26, 2025
12 of 13 checks passed
@sheremet-va sheremet-va deleted the refactor/use-context-on-synthetic-module branch March 26, 2025 19:34
@renovate renovate bot mentioned this pull request Apr 14, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request Jun 2, 2025
Open
1 task
This was referenced Jun 10, 2025
Open
Merged
This was referenced Jul 19, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AriPerkkio AriPerkkio AriPerkkio left review comments

@hi-ogawa hi-ogawa Awaiting requested review from hi-ogawa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sheremet-va @AriPerkkio