Skip to content

Comments

fix(reporter): print test only once in the verbose mode#7738

Merged
sheremet-va merged 18 commits intovitest-dev:mainfrom
sheremet-va:fix/print-tst-once
Mar 31, 2025
Merged

fix(reporter): print test only once in the verbose mode#7738
sheremet-va merged 18 commits intovitest-dev:mainfrom
sheremet-va:fix/print-tst-once

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Mar 25, 2025 •
edited
Loading

Description

I decided to remove the printTask function and refactor it using the new hooks instead 👀

Fixes #7729

There are already tests covering verbose reporter (thank you Ari 🙏🏻 )

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Mar 25, 2025 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit f3f4066
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67ea64c74c8b4f0008e26bb8
😎 Deploy Preview https://deploy-preview-7738--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sheremet-va
sheremet-va commented Mar 25, 2025
View reviewed changes
sheremet-va
sheremet-va commented Mar 25, 2025
View reviewed changes
AriPerkkio
AriPerkkio reviewed Mar 27, 2025
View reviewed changes
@sheremet-va sheremet-va added this to the 3.1.0 milestone Mar 28, 2025
This was referenced Mar 28, 2025
Merged
Closed
@sheremet-va sheremet-va requested a review from AriPerkkio March 28, 2025 13:55
@AriPerkkio AriPerkkio changed the title fix: print test only once in the verbose mode fix(reporter): print test only once in the verbose mode Mar 29, 2025
AriPerkkio
AriPerkkio previously approved these changes Mar 29, 2025
View reviewed changes
@sheremet-va sheremet-va merged commit 69ca425 into vitest-dev:main Mar 31, 2025
11 of 13 checks passed
@sheremet-va sheremet-va deleted the fix/print-tst-once branch March 31, 2025 10:12
@renovate renovate bot mentioned this pull request Apr 6, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request Apr 15, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request May 5, 2025
Open
1 task
This was referenced Jun 13, 2025
Open
Open
@renovate renovate bot mentioned this pull request Aug 9, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AriPerkkio AriPerkkio AriPerkkio left review comments

@hi-ogawa hi-ogawa Awaiting requested review from hi-ogawa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

verbose reporter on CI shows duplicate lines with afterEach

2 participants

@sheremet-va @AriPerkkio