fix(reporter): --hideSkippedTests should hide suites too#7695
Merged
hi-ogawa merged 1 commit intovitest-dev:mainfrom Mar 19, 2025
Merged
fix(reporter): --hideSkippedTests should hide suites too#7695hi-ogawa merged 1 commit intovitest-dev:mainfrom
--hideSkippedTests should hide suites too#7695hi-ogawa merged 1 commit intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
AriPerkkio
force-pushed
the
fix/hide-skipped-tests-hide-suites
branch
from
eca4f94 to
32908a1
Compare
hi-ogawa
approved these changes
Mar 19, 2025
Contributor
hi-ogawa
left a comment
hi-ogawa
left a comment
There was a problem hiding this comment.
Thanks!
Btw, I haven't notice the issue with the default reporter, so is this only for verbose reporter?
Member
Author
|
Yes, I think this affects only verbose reporter. The default/base reporter renders tests and their suites on the same line, so hiding affects whole row. This issue came up only after #7503. |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--hideSkippedTestsis used.Noticed this verbose noise in my project even when using
hideSkippedTests: true:With this fix it becomes much easier to read:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.