fix: typings of ctx.skip() as never#7608
Merged
AriPerkkio merged 1 commit intovitest-dev:mainfrom Mar 7, 2025
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Since `skip` throws an error, its return type should be set to `never` so that TypeScript & linters can determine that this code path ends.
AriPerkkio
reviewed
Mar 5, 2025
Member
AriPerkkio
left a comment
AriPerkkio
left a comment
There was a problem hiding this comment.
How does this change come up in practice when writing test cases?
Contributor
Author
|
When I was writing a test that used |
AriPerkkio
approved these changes
Mar 7, 2025
AriPerkkio
changed the title
skip as never returningctx.skip() as never
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
skipthrows an error, its return type should be set toneverso that TypeScript & linters can determine that this code path ends.Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.