Skip to content

Comments

chore(expect-type): update expect-type usage#7589

Closed
mmkal wants to merge 5 commits intovitest-dev:mainfrom
mmkal:mk/expect-type-1.2.0
Closed

chore(expect-type): update expect-type usage#7589
mmkal wants to merge 5 commits intovitest-dev:mainfrom
mmkal:mk/expect-type-1.2.0

Conversation

@mmkal
Copy link
Contributor

@mmkal mmkal commented Feb 28, 2025

Description

Just getting ahead of renovate-bot and bumping expect-type because there are some downstream projects I'd like to get the new features in.

New features in expect-type:

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] [no issue, it's just a dependency update so hopefully fine?] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • [ ] [updated a test, but didn't see a need for a new one] Ideally, include a test that fails without this PR but passes with it.
  • [ ] [lockfile was updated, because it's a deps bump] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci. [some failures on my machine, but I think unrelated]

Documentation

  • [ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f8ab2f5
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/685188ea7c8d340008580e33
😎 Deploy Preview https://deploy-preview-7589--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va
Copy link
Member

I think new features should be documented in https://vitest.dev/api/expect-typeof.html

@mmkal mmkal marked this pull request as draft March 7, 2025 19:23
@mmkal
Copy link
Contributor Author

mmkal commented Mar 7, 2025

@sheremet-va sounds good, will update that page soon, have set to draft in the meantime.

Also is the breaking-change label because the method is deprecated? All existing toMatchTypeOf will continue to work as-is. No plans for a runtime or compile time breaking change, but maybe the stance in vitest is that the @deprecated tag counts as breaking? If so, I might un-deprecated and just recommend the other method in docs. I don't think the deprecation is really worth waiting for a major bump of vitest for, unless one is coming imminently anyway.

@sheremet-va
Copy link
Member

Sorry I misunderstood the change. I thought that the old methods are going away because you updated the tests. It's fine to keep as a feature release

@mmkal mmkal changed the title chore(deps): bump expect-type to ^1.2.0 chore(expect-type): update expect-type usage Jun 17, 2025
@sheremet-va
Copy link
Member

I think this can be closed since #8397 added this information already

@sheremet-va sheremet-va closed this Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants