fix(snapshot): fix indent normalization#7400
Merged
sheremet-va merged 4 commits intovitest-dev:mainfrom Mar 28, 2025
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
force-pushed
the
fix-snapshot-object-indent-detection
branch
from
a513cdf to
b58d470
Compare
hi-ogawa
changed the title
Member
|
I think this is needed to respect the file identation. If you don't have this, it will create generate this: // ... a lot of tests
expect().toBeUndefined()
expect().toMatchInlineSnapshot(`
{
foo: true
}
`Now it does this: // ... a lot of tests
expect().toBeUndefined()
expect().toMatchInlineSnapshot(`
{
foo: true
}
` |
Contributor
Author
Can you provide runnable code? I don't think this PR changes indent of snapshots generation. That would've been caught by |
sheremet-va
approved these changes
Mar 28, 2025
1 task
1 task
Tobbe
added a commit
to cedarjs/cedar
that referenced
this pull request
Jun 28, 2025
I was upgrading to Vitest 3.x and noticed one of our snapshot tests started failing. Looking into it I realized we weren't handling whitespace properly when setting up Supertokens auth. This PR fixes that. I'm guessing this is the Vitest change that caused the diff in snapshots: vitest-dev/vitest#7400 It doesn't say in the PR description, but the [release notes for Vitest 3.1.0](https://github.com/vitest-dev/vitest/releases/tag/v3.1.0), where it was first included, says > This change can cause small amount of very old snapshots to be updated, but there will be no functional change to how they work.
Tobbe
added a commit
to cedarjs/cedar
that referenced
this pull request
Jun 28, 2025
Updates from Vite 2.x to latest 3.x release Had to update two tests because of breaking changes between v2 and v3 vitest-dev/vitest#5876 vitest-dev/vitest#7400
Tobbe
added a commit
to cedarjs/cedar
that referenced
this pull request
Jul 6, 2025
I was upgrading to Vitest 3.x and noticed one of our snapshot tests started failing. Looking into it I realized we weren't handling whitespace properly when setting up Supertokens auth. This PR fixes that. I'm guessing this is the Vitest change that caused the diff in snapshots: vitest-dev/vitest#7400 It doesn't say in the PR description, but the [release notes for Vitest 3.1.0](https://github.com/vitest-dev/vitest/releases/tag/v3.1.0), where it was first included, says > This change can cause small amount of very old snapshots to be updated, but there will be no functional change to how they work.
Tobbe
added a commit
to cedarjs/cedar
that referenced
this pull request
Jul 6, 2025
Updates from Vite 2.x to latest 3.x release Had to update two tests because of breaking changes between v2 and v3 vitest-dev/vitest#5876 vitest-dev/vitest#7400
quilicicf
added a commit
to quilicicf/mermaid
that referenced
this pull request
Jul 14, 2025
Ran `pnpm update` and fixed these two issues : * Line breaks removed from nested lists in mardkown, see [Prettier release notes](https://prettier.io/blog/2025/06/23/3.6.0#change-16637) * Vitest snapshots indent normalization, see [Vitest release notes](https://github.com/vitest-dev/vitest/releases/tag/v3.1.0) ([relevant change](vitest-dev/vitest#7400))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I couldn't tell why
prepareExpectedis needed sincestripSnapshotIndentationalready takes care of inline snapshot indent normalization. RemovingprepareExpecteddidn't break any tests, such as the ones added in #1232.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.