chore(ui): fix static ui client types#7201
Merged
sheremet-va merged 5 commits intomainfrom Jan 12, 2025
Merged
Conversation
userquin
commented
Jan 11, 2025
6 tasks
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
requested changes
Jan 12, 2025
test/browser/vitest.config.mts
Outdated
| diff: './custom-diff-config.ts', | ||
| outputFile: './browser.json', | ||
| reporters: ['json', { | ||
| outputFile, |
Member
There was a problem hiding this comment.
I don't understand why this needs to be conditional when we support objects if you use several reporters:
outputFile: {
html: './html/index.html',
json: './browser.json'
}
sheremet-va
approved these changes
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The static module doesn't include the new
rerunTaskadded to run individual tests in the new UI, and theopenPromisenot being initialized (Variable openPromise is used before being assigned.).This PR also includes:
test/coreandtest/browsertest/core/htmlandtest/browser/htmlto.gitignorepackages/ui/clientfolder intsctypecheck script: fixed failing modulesFIXED: We need to check why running the html reporter on
test/browserdoesn't generate the html folder, it is generating the app inside thetest/browserfolder. usingjsonreporter andoutputFile: './browser.jsonI'm going to send 2 new PR for:
fix html reporter output folder when running browser modevue-tscto validate also vue files inpackages/ui/clientPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.