Skip to content

Comments

WIP: feat (ui): insert filter by workspace in vitest ui#7157

Closed
DevJoaoLopes wants to merge 5 commits intovitest-dev:mainfrom
DevJoaoLopes:feature-vitest-ui-workspace-scenarios
Closed

WIP: feat (ui): insert filter by workspace in vitest ui#7157
DevJoaoLopes wants to merge 5 commits intovitest-dev:mainfrom
DevJoaoLopes:feature-vitest-ui-workspace-scenarios

Conversation

@DevJoaoLopes
Copy link
Contributor

@DevJoaoLopes DevJoaoLopes commented Jan 2, 2025

Description

This PR is still under development and refers to issue #7089

To Do List:

  • Simple visual component of select for filtering
  • Add logic for filters
  • Add test coverage
  • Validate types

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 815a7fb
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/679212c80928d6000828d9a6
😎 Deploy Preview https://deploy-preview-7157--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DevJoaoLopes DevJoaoLopes marked this pull request as draft January 6, 2025 22:38
@@ -0,0 +1,54 @@
<script lang="ts">
Copy link
Member

@sheremet-va sheremet-va Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a heads up, but we don't use object syntax, only script setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfectly, thanks for letting me know @sheremet-va 😄

Copy link
Member

@userquin userquin Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need this PR #7146 or maybe we will need to add a new rpc call, right now running all the tests since we sent the files (missing project).

We should also remove project from local storage, we don't have the projects in the configuration and so we will need to reset it, maybe we should expose the projects in the configuration, otherwise we will have some race condition on initial load.

For example, using this PR modified on my local and re-running the forks project in test/core:

imagen
running forks on my local with this PR modified

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@userquin I understand, the PR #7146 is ready just waiting for revisions

@userquin
Copy link
Member

userquin commented Jan 12, 2025

can you merge main once #7213 merged and resolve conflicts? Once my PR merged, we'll have the projects available in the tree or whatever we want to move it

@DevJoaoLopes
Copy link
Contributor Author

Of course, I'll do that soon. Thank you @userquin

@DevJoaoLopes DevJoaoLopes force-pushed the feature-vitest-ui-workspace-scenarios branch from b895c02 to ac4e505 Compare January 13, 2025 11:30
@DevJoaoLopes DevJoaoLopes deleted the feature-vitest-ui-workspace-scenarios branch April 6, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants