refactor: merge TestProject with WorkspaceProject#6906
Merged
sheremet-va merged 17 commits intovitest-dev:mainfrom Nov 18, 2024
Merged
refactor: merge TestProject with WorkspaceProject#6906sheremet-va merged 17 commits intovitest-dev:mainfrom
TestProject with WorkspaceProject#6906sheremet-va merged 17 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TestProject with WorkspaceProject
16bdea0 to
14c6bb6
Compare
AriPerkkio
reviewed
Nov 15, 2024
AriPerkkio
reviewed
Nov 17, 2024
Member
AriPerkkio
left a comment
There was a problem hiding this comment.
The overall direction is great! Thanks for working on this 🙌
Co-authored-by: Ari Perkkiö <[email protected]>
hi-ogawa
reviewed
Nov 18, 2024
Contributor
hi-ogawa
left a comment
There was a problem hiding this comment.
I wasn't aware of the much of API, but I like the idea of merging and simplifying WorkspaceProject and TestProject 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for the public API. Previously
TestProjectwas a prototype for the public API, but it was hard to work with internally because it was too restrictive. In this PR I decided to merge them together and introduce a sort of convention:_and marked with@internalare internal and not part of the public API. They are striped from the public interface during bundling@deprecatedtag - they will be removed in V3 (we can remove them right away, they shouldn't have been used at all)WorkspaceProjectwas renamed toTestProject- all properties from the test project are now present there. The file was also renamed fromworkspacetoproject.viteor.configwas accessed before the project was initialised. This should catch unexpected errors with a nice stack traceThe public test project API now looks like this (excluding deprecated and private APIs):
TODO:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.