Skip to content

Comments

chore: test Vite PR 18329#6696

Closed
hi-ogawa wants to merge 4 commits intovitest-dev:mainfrom
hi-ogawa:chore-vite-ssr-identity
Closed

chore: test Vite PR 18329#6696
hi-ogawa wants to merge 4 commits intovitest-dev:mainfrom
hi-ogawa:chore-vite-ssr-identity

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Oct 12, 2024 •
edited
Loading

Description

Sourcemap viz of fixtures/src/Vue/Counter/Counter.vue

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Oct 12, 2024

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit aa77ad7
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/670a17ede5cdbf00089c9ae9
😎 Deploy Preview https://deploy-preview-6696--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AriPerkkio
AriPerkkio requested changes Oct 13, 2024
View reviewed changes
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hi-ogawa could you try if commenting out this part fixes the coverage? The new helper method added by Vite is on first line so I wonder if that's breaking here.

vitest/packages/vite-node/src/source-map.ts

Lines 64 to 68 in c4076e6

// If the first line is not present on source maps, add simple 1:1 mapping ([0,0,0,0], [1,0,0,0])
// so that debuggers can be set to break on first line
if (map.mappings.startsWith(';')) {
map.mappings = `AAAA,CAAA${map.mappings}`
}

@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Oct 13, 2024

@AriPerkkio Good find! Commenting out that mapping fixed the issue. There is a diff in lines and statements, but I can see the same diff on main when I comment out the same line, so I suppose it's been affecting the coverage already.

I guess we need to find a different way to make inspect-brk work.

@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Oct 13, 2024

For example, currently the first line <script setup lang="ts"> is considered covered:

but it's removed after removing first line mapping:

@AriPerkkio
Copy link
Member

AriPerkkio commented Oct 13, 2024

I guess we need to find a different way to make inspect-brk work.

I think for now it would be enough to set this breakpoint when we detect that vitest --inspect-brk is used.

@hi-ogawa hi-ogawa mentioned this pull request Oct 17, 2024
Closed
6 tasks
@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Oct 18, 2024

Closing in favor of #6732

@hi-ogawa hi-ogawa closed this Oct 18, 2024
@hi-ogawa hi-ogawa deleted the chore-vite-ssr-identity branch October 18, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AriPerkkio AriPerkkio AriPerkkio requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hi-ogawa @AriPerkkio