Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| { size: mainSizes.value[0] }, | ||
| { size: mainSizes.value[1] }, | ||
| ]) | ||
| if (browserState) { |
There was a problem hiding this comment.
Why did it suddenly stop recording the main resize? recordMainResize affects how the browser displays panels
There was a problem hiding this comment.
We drop the middle panel in the default ui
There was a problem hiding this comment.
But we don't drop it in the browser
There was a problem hiding this comment.
The issue is in the ui not in the browser ui
There was a problem hiding this comment.
Are you saying it is ok to break the browser UI?
There was a problem hiding this comment.
No, I need to test the changes in the browser ui, this change just fix the ui.
This shouldn't break the browser ui, the logic is the same, we only initilize the ui panels properly.
The problem is about using the same storage key for both, the ui and the browser ui.
Try deleting the |
|
Superseded by #7265 |
2 participants
Description
Cannot test browser ui on my local Windows laptop, we need to check the side effect opening UI (test/core) and then the Browser UI (test/browser running any
test:browser:*script)resolves #6678
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.