Skip to content

Comments

feat: #4010 Displays time in green#6432

Closed
spamshaker wants to merge 3 commits intovitest-dev:mainfrom
spamshaker:#4010-patch
Closed

feat: #4010 Displays time in green#6432
spamshaker wants to merge 3 commits intovitest-dev:mainfrom
spamshaker:#4010-patch

Conversation

@spamshaker
Copy link
Contributor

@spamshaker spamshaker commented Sep 1, 2024

Description

#4010 Displays test time in green

image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9592d0c
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66e541a8c21f4b0008ed0bcc
😎 Deploy Preview https://deploy-preview-6432--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Michał Grzegorzewski and others added 2 commits September 1, 2024 10:29
Consolidate import statements for better readability and reformat the duration suffix assignment to maintain consistent style across code sections. This change improves code clarity and consistency.
@sheremet-va sheremet-va added the p2-to-be-discussed Enhancement under consideration (priority) label Sep 26, 2024
Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The team thinks it's a nice feature to have, but you missed the non-tty use case in the verbose reporter:

and in the base reporter:

protected printTask(task: Task) {

@sheremet-va sheremet-va added p2-nice-to-have Not breaking anything but nice to have (priority) and removed p2-to-be-discussed Enhancement under consideration (priority) labels Oct 29, 2024
@AriPerkkio
Copy link
Member

This outdated PR contained changes to files that no longer exist, so I created new PR that finalizes the changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants