✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	95a1d1c
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/66c7bf6c885d9c000843e32d
😎 Deploy Preview	https://deploy-preview-6378--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Hey, I'd appreciate some input on the CI failing - node-20, macos-14 was passing before my rebase onto main 🤔

Hey, I'd appreciate some input on the CI failing - node-20, macos-14 was passing before my rebase onto main 🤔

It's just flaky, don't worry

The team thinks it's better to restore the implementation in mockRevert instead of resetting it to a () => {} without adding a new method.

mockRevert is the function this PR adds - do you mean mockReset ?

Wouldn't that be a breaking change with respect to the Jest compatibility layer?

I am imagining like:

import { expect, it, vi } from "vitest"

// this test passes with jest
// it would not pass in vitest with the proposed changes to `mockReset`
it("should reset", () => {
  const value = 0
  const fn = vi.fn(() => {
    value++
  })
  fn()
  expect(value).toBe(1)
  fn.mockReset()
  fn()
  expect(value).toBe(1)
})

Please let me know if I have misunderstood anything ❤️

Sorry, I am happy to help, I just want to make sure the discussion was rigorous before proceeding 😅

mockRevert is the function this PR adds - do you mean mockReset ?

Wouldn't that be a breaking change with respect to the Jest compatibility layer?

Yes and yes

Alright - I think I will close this for now, then, and open a new PR for that