Skip to content

Comments

fix(reporter): use default error formatter for JUnit#5626

Closed
hi-ogawa wants to merge 4 commits intomainfrom
fix-junit-error-format
Closed

fix(reporter): use default error formatter for JUnit#5626
hi-ogawa wants to merge 4 commits intomainfrom
fix-junit-error-format

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Apr 26, 2024 •
edited
Loading

Description

Since we now have reusable printErrorWrapper (introduced for github actions reporter #5093) to generate the default error formatting, probably using it for Junit would make sense.

This wrapper supports all the good things automatically:

  • expected/actual diff
  • stack
  • formatting of throw {somePlainObject} (which is what OP mentioned)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited
Loading

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit ed781d5
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/662b814c8a0e9e0008170970

@hi-ogawa hi-ogawa changed the title fix(reporter/junit): use same error formatting as default reporter fix(reporter): use default error formatter for junit Apr 26, 2024
@hi-ogawa hi-ogawa changed the title fix(reporter): use default error formatter for junit fix(reporter): use default error formatter for JUnit Apr 26, 2024
hi-ogawa
hi-ogawa commented Apr 26, 2024
View reviewed changes
packages/vitest/src/node/reporters/junit.ts
this.ctx,
this.ctx.getProjectByTaskId(task.id),
)
await this.baseLog(escapeXML(stripAnsi(result.output.trim())))
Copy link
Contributor Author

@hi-ogawa hi-ogawa Apr 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stripped the color for now, but it would be cool to have diff color if we can expect many consumers of junit reporter supports ansi code on their UI.
From the OP's screenshot, CircleCI probably supports it.

@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Apr 27, 2024

I just noticed I've been pushing a branch directly on this repo...
Let me close this one and I'll recreate a PR from my fork

@hi-ogawa hi-ogawa closed this Apr 27, 2024
@hi-ogawa hi-ogawa deleted the fix-junit-error-format branch April 27, 2024 00:09
@hi-ogawa hi-ogawa mentioned this pull request Apr 27, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JUnit reporter: ‘Unknown Error: undefined’

1 participant

@hi-ogawa