Skip to content

Comments

chore(deps): update webdriverio 8.32.2 to fix chrome download issue#5240

Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom
hi-ogawa:chore-deps-webdriverio-chrome
Feb 20, 2024
Merged

chore(deps): update webdriverio 8.32.2 to fix chrome download issue#5240
sheremet-va merged 2 commits intovitest-dev:mainfrom
hi-ogawa:chore-deps-webdriverio-chrome

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 19, 2024

Description

It seems like chrome download issue is fixed, but the issue is still open, so maybe other drivers got problems.
I guess we'll see how it goes on CI.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit f55b6bc
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65d3e4182952f5000842e271
😎 Deploy Preview https://deploy-preview-5240--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa mentioned this pull request Feb 20, 2024
6 tasks
@sheremet-va sheremet-va merged commit 09c1c76 into vitest-dev:main Feb 20, 2024
@hi-ogawa hi-ogawa deleted the chore-deps-webdriverio-chrome branch February 20, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants