fix(vitest): disable optimizer by default until it's stable#5156
Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom Feb 12, 2024
Merged
fix(vitest): disable optimizer by default until it's stable#5156sheremet-va merged 1 commit intovitest-dev:mainfrom
sheremet-va merged 1 commit intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hi-ogawa
approved these changes
Feb 12, 2024
Contributor
hi-ogawa
left a comment
There was a problem hiding this comment.
Sounds good to me. Considering the issue with ssr.optimizeDeps #4910 is fixed since Vite 5.1 vitejs/vite#15561, I think this affects jsdom/happy-dom use cases mostly.
7 tasks
6 tasks
6 tasks
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The optimizer is not stable enough at this point (some packages like
reactdon't work with it and if all dependencies are not pre-bundled, there is a high chance users will get a "Cannot find module" error only in CI which is hard to debug). Since Vitest 1.3.0 focuses more on stability, we are disabling this option until we can figure out a good way to enable it without these hazards. If your tests are slower after this PR, you can always enable optimizer manually:Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.