fix: one-line environment options#5105
Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom Jul 15, 2024
Merged
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
hahanein
changed the title
Contributor
Maybe you forgot Lines 16 to 22 in cfd0611 |
Member
|
Any changes? |
hahanein
force-pushed
the
environment-options-bug
branch
from
597d80c to
f851982
Compare
hahanein
force-pushed
the
environment-options-bug
branch
from
0902212 to
49c3315
Compare
Previously vitest failed to parse environment options when they were
provided as a single line doc block like so:
/** @vitest-environment-options {"url": "https://vitejs.dev"} */
The regular expression erroneously captured the JSON as well as " */".
hahanein
force-pushed
the
environment-options-bug
branch
from
49c3315 to
f88348b
Compare
Contributor
Author
|
I updated the pull request and use |
sheremet-va
approved these changes
Jul 15, 2024
This was referenced Aug 21, 2024
This was referenced Aug 28, 2024
This was referenced Sep 10, 2024
This was referenced Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #5104
Environment options cannot be parsed when declared like so:
The regexp captures
{"url": "https://vitejs.dev"} */I would like to add tests but I get hit with the following error message when trying to run them:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.