Skip to content

Comments

fix(threads): mention common work-around for the logged error#5024

Merged
AriPerkkio merged 1 commit intovitest-dev:mainfrom
AriPerkkio:feat/extend-error-message
Jan 26, 2024
Merged

fix(threads): mention common work-around for the logged error#5024
AriPerkkio merged 1 commit intovitest-dev:mainfrom
AriPerkkio:feat/extend-error-message

Conversation

@AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jan 21, 2024

Description

Include common work-around for the logged errors so that users don't need to look for it themselves. I've already lost count of how many times --pool=forks has resolved similar issues. Related to #3077.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit bb52531
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65afe7203eb14800084f2944
😎 Deploy Preview https://deploy-preview-5024--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio AriPerkkio changed the title feat(threads): mention common work-around for the logged error fix(threads): mention common work-around for the logged error Jan 22, 2024
@AriPerkkio AriPerkkio force-pushed the feat/extend-error-message branch from e622d77 to bb52531 Compare January 23, 2024 16:19
@AriPerkkio
Copy link
Member Author

Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AriPerkkio AriPerkkio merged commit 915d6c4 into vitest-dev:main Jan 26, 2024
@AriPerkkio AriPerkkio deleted the feat/extend-error-message branch January 26, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants