fix(vitest): handle single await vi.hoisted#4962
Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom Jan 15, 2024
Merged
fix(vitest): handle single await vi.hoisted#4962sheremet-va merged 2 commits intovitest-dev:mainfrom
await vi.hoisted#4962sheremet-va merged 2 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
sheremet-va
requested changes
Jan 15, 2024
This was referenced Jan 16, 2024
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
await vi.hoistednot hoisted when used alone #4941I loosened regex to match
(vi|vitest).(mock|unmock|hoisted)anywhere in the code (not necessary assignment nor beginning of line).Btw, it looks like currently tests are failing locally when color is enabled probably because of code frame offset not taking account highlight:
vitest/packages/vitest/src/node/hoistMocks.ts
Line 259 in 0b28f30
So, for now I verified it by running with
NO_COLOR=1.(I tried to reproduced it but it doesn't look like highlight is enabled in user's tests https://stackblitz.com/edit/vitest-dev-vitest-nanulr?file=test%2Frepro.test.ts)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.