fix(expect): implement chai inspect for `AsymmetricMatcher` by hi-ogawa · Pull Request #4942 · vitest-dev/vitest

hi-ogawa · 2024-01-12T09:13:36Z

Description

Related to Preserve asymmetric matcher messages #4093
- the issue also mentions toThrow error message but that's not addressed in this PR

By implementing custom "inspect" method, it can improve AssertionError.message generated by chai/loupe.

In terms of Jest feature parity, it's difficult to compare because Jest doesn't seem to show the detail in the "message". I tested a same example on jest and its output is like this:

https://stackblitz.com/edit/github-o6sfsk?file=tests%2Fjest.test.cjs

    Message:
      expect(received).toEqual(expected) // deep equality   //// <-- jest is super simple here  
    
    Expected: myStringContaining<xx>
    Received: "hello"

    Difference:

    Compared values have no visual difference.Error:

      21 |
      22 | test("custom error 1", () => {
    > 23 |   expect("hello").toEqual(expect.myStringContaining("xx"));
         |                   ^
      24 | });

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2024-01-12T09:13:41Z

✅ Deploy Preview for fastidious-cascaron-4ded94 ready!

Name	Link
🔨 Latest commit	`555324e`
🔍 Latest deploy log	https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65a534cf3b515800080d8354
😎 Deploy Preview	https://deploy-preview-4942--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

feat(expect): implement chai inspect for AsymmetricMatcher

8ed285e

sheremet-va approved these changes Jan 12, 2024

View reviewed changes

hi-ogawa added 8 commits January 12, 2024 18:44

test: test more complex

279fbbc

chore: comment

609b4b4

test: test objectContaining

4ce3f44

test: more builtins

d0793f6

fix: truncate if too long

3b8f27e

refactor: clenaup

3092d10

Merge branch 'main' into feat-asymmetric-matcher-loupe-inspect

b12c6a8

test: tweak

81b6511

hi-ogawa marked this pull request as ready for review January 13, 2024 01:36

sheremet-va changed the title ~~feat(expect): implement chai inspect for AsymmetricMatcher~~ fix(expect): implement chai inspect for AsymmetricMatcher Jan 15, 2024

sheremet-va approved these changes Jan 15, 2024

View reviewed changes

Merge branch 'main' into feat-asymmetric-matcher-loupe-inspect

555324e

sheremet-va merged commit 06bae4d into vitest-dev:main Jan 15, 2024

hi-ogawa deleted the feat-asymmetric-matcher-loupe-inspect branch January 17, 2024 03:13

hi-ogawa mentioned this pull request Jan 18, 2024

fix(expect): improve toThrow(asymmetricMatcher) failure message #5000

Merged

6 tasks

renovate bot mentioned this pull request Jan 24, 2024

chore(deps): update all non-major dependencies nuxt/eslint#323

Closed

1 task

renovate bot mentioned this pull request Jan 28, 2024

Update devDependencies NullVoxPopuli/limber#1624

Merged

1 task

renovate bot referenced this pull request in JoshuaKGoldberg/create-typescript-app Feb 27, 2024

chore(deps): update dependency vitest to v1.3.1 (#1351

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(expect): implement chai inspect for `AsymmetricMatcher`#4942

fix(expect): implement chai inspect for `AsymmetricMatcher`#4942
sheremet-va merged 10 commits intovitest-dev:mainfrom
hi-ogawa:feat-asymmetric-matcher-loupe-inspect

hi-ogawa commented Jan 12, 2024 •

edited

Loading

Uh oh!

netlify bot commented Jan 12, 2024 •

edited

Loading

Uh oh!

Uh oh!

Comments

Conversation

hi-ogawa commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

netlify bot commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fastidious-cascaron-4ded94 ready!

Uh oh!

hi-ogawa commented Jan 12, 2024 •

edited

Loading

netlify bot commented Jan 12, 2024 •

edited

Loading