fix(vitest): test deep dependencies change detection#4934
Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom Jan 20, 2024
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--changedflag is not correctly looking up deep dependencies, as such the changed flag does not trigger specs if a sub dependency is changed.Alters the logic to add the collected dependency after recursive
addImportsis called, otherwise the logic returns early because that dependency has already been added to the collected deps set. So it will not look deeply.Resolves #4933
(Also Resolves #5009)