Skip to content

fix(vitest): show beforeAll/afterAll errors in junit reporter#4819

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
hi-ogawa:fix-junit-suite-errors
Dec 31, 2023
Merged

fix(vitest): show beforeAll/afterAll errors in junit reporter#4819
sheremet-va merged 1 commit intovitest-dev:mainfrom
hi-ogawa:fix-junit-suite-errors

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Dec 29, 2023 •
edited
Loading

Description

Closes #4516

This PR is an alternative of #4799 to surface beforeAll/afterAll errors in junit reporter.

This approach might not be the most sound one since it "mutates" test counts when beforeAll/afterAll failed, but this will ensure such suite-level errors will be recorded in the report.

The idea came from how default reporters shows "Failed Suites" separately from "Failed Tests":

vitest/packages/vitest/src/node/reporters/base.ts

Lines 290 to 302 in 5ee041d

const failedSuites = suites.filter(i => i.result?.errors)
const failedTests = tests.filter(i => i.result?.state === 'fail')
const failedTotal = countTestErrors(failedSuites) + countTestErrors(failedTests)
let current = 1
const errorDivider = () => logger.error(`${c.red(c.dim(divider(`[${current++}/${failedTotal}]`, undefined, 1)))}\n`)
if (failedSuites.length) {
logger.error(c.red(divider(c.bold(c.inverse(` Failed Suites ${failedSuites.length} `)))))
logger.error()
await this.printTaskErrors(failedSuites, errorDivider)
}

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Dec 29, 2023 •
edited
Loading

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 5ee041d
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/658e75e5ed4f11000802672c

@hi-ogawa hi-ogawa mentioned this pull request Dec 29, 2023
Closed
6 tasks
@hi-ogawa hi-ogawa changed the title fix(vitest): show beforeAll/afterAll errors in junit reporter fix(vitest): show beforeAll/afterAll errors in junit reporter Dec 29, 2023
@hi-ogawa hi-ogawa marked this pull request as ready for review December 29, 2023 07:43
@sheremet-va sheremet-va merged commit 2baea35 into vitest-dev:main Dec 31, 2023
@hi-ogawa hi-ogawa deleted the fix-junit-suite-errors branch January 2, 2024 00:56
@renovate renovate bot mentioned this pull request Jan 3, 2024
Merged
1 task
@renovate renovate bot mentioned this pull request Jan 21, 2024
Open
1 task
This was referenced Apr 11, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JUNIT reporter doesn't mark test as failed if the beforeAll throws error

2 participants

@hi-ogawa @sheremet-va