Skip to content

Comments

feat: Add typeahead search (#4275)#4733

Merged
sheremet-va merged 17 commits intovitest-dev:mainfrom
bonyuta0204:feature/add-typeahead-search
Jan 12, 2024
Merged

feat: Add typeahead search (#4275)#4733
sheremet-va merged 17 commits intovitest-dev:mainfrom
bonyuta0204:feature/add-typeahead-search

Conversation

@bonyuta0204
Copy link
Contributor

@bonyuta0204 bonyuta0204 commented Dec 11, 2023

Description

This pull request aims to improve the developer experience (DX) in Vitest's watch mode by introducing an interactive file selection feature. When filtering by filename pattern, Vitest will present a dynamically updated list of files that match the user's current input. This enhancement is inspired by the functionality available in jest-watch-typeahead, offering users a more intuitive and efficient way to select specific tests to run.

Related Issue

Closes #4275

Demo

File pattern

arrow-key-paging.mp4

Test name pattern

test_name_pattern.mp4

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit d24e28c
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/659c0b261ee8a60008471fc3
😎 Deploy Preview https://deploy-preview-4733--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bonyuta0204
Copy link
Contributor Author

bonyuta0204 commented Dec 11, 2023

To-Do List

  • Convert Path to Relative Path

    • Convert absolute paths to relative paths for better readability.
  • Handle Excessive Search Results

    • Implement a limit or pagination for large result sets.

@bonyuta0204 bonyuta0204 force-pushed the feature/add-typeahead-search branch 5 times, most recently from 6dde1a1 to 24506ea Compare December 16, 2023 10:39
@bonyuta0204 bonyuta0204 force-pushed the feature/add-typeahead-search branch 3 times, most recently from 4626fee to 1969126 Compare December 21, 2023 14:51
@bonyuta0204 bonyuta0204 marked this pull request as ready for review December 23, 2023 03:30
@bonyuta0204
Copy link
Contributor Author

@sheremet-va
The pull request is now prepared for review. Your feedback would be greatly appreciated!

@bonyuta0204 bonyuta0204 force-pushed the feature/add-typeahead-search branch from 3ebed7a to f0e1cb6 Compare December 31, 2023 01:15
@bonyuta0204 bonyuta0204 force-pushed the feature/add-typeahead-search branch 3 times, most recently from 2e02bbb to 7acd51b Compare December 31, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add typeahead to watch mode filename filter

3 participants