Skip to content

Comments

feat(ui): show unhandled errors on the ui#4380

Merged
sheremet-va merged 26 commits intovitest-dev:mainfrom
spiroka:unhandled-errors-in-ui
Jan 12, 2024
Merged

feat(ui): show unhandled errors on the ui#4380
sheremet-va merged 26 commits intovitest-dev:mainfrom
spiroka:unhandled-errors-in-ui

Conversation

@spiroka
Copy link
Contributor

@spiroka spiroka commented Oct 26, 2023 •
edited
Loading

Description

Adds info about unhandled errors to the ui and html reports.

Screenshot 2023-12-15 at 21 08 39 Screenshot 2023-12-15 at 21 08 28

closes #4317

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Oct 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Oct 26, 2023 •
edited
Loading

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit a8da5cd
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65a1458c6957330008fd7767

@dammy001
Copy link
Member

dammy001 commented Oct 31, 2023

@spiroka this ready for review?

@spiroka
Copy link
Contributor Author

spiroka commented Oct 31, 2023

@spiroka this ready for review?

Not yet. I will add some tests and rebase.
Also thinking about what the best way is to show the actual errors to users. I'm leaning towards just telling them to check the terminal for stack traces as I don't want to clutter the UI with them. Any thoughts?

@spiroka spiroka force-pushed the unhandled-errors-in-ui branch from 3263aa8 to 3a71dc1 Compare November 2, 2023 20:18
@spiroka spiroka marked this pull request as ready for review November 2, 2023 20:36
@spiroka
Copy link
Contributor Author

spiroka commented Nov 2, 2023

@dammy001
I've added tests. The PR is ready for review.

sheremet-va
sheremet-va reviewed Nov 13, 2023
View reviewed changes
sheremet-va
sheremet-va requested changes Nov 15, 2023
View reviewed changes
@spiroka spiroka marked this pull request as draft November 19, 2023 19:15
sheremet-va
sheremet-va reviewed Nov 19, 2023
View reviewed changes
packages/ui/client/components/dashboard/ErrorEntry.vue Outdated
@@ -0,0 +1,60 @@
<script setup lang="ts">
import { isPrimitive } from 'vitest/utils'
Copy link
Member

@sheremet-va sheremet-va Nov 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't import from vitest/ in UI package. Only relative paths are allowed there. This particular function can just be inlined

@spiroka spiroka marked this pull request as ready for review November 21, 2023 08:08
renovate bot referenced this pull request in JoshuaKGoldberg/all-contributors-auto-action Feb 26, 2024
@renovate
chore(deps): update dependency vitest to v1.3.1 (#247)
635aa6f 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [vitest](https://togithub.com/vitest-dev/vitest)
([source](https://togithub.com/vitest-dev/vitest/tree/HEAD/packages/vitest))
| [`1.1.3` ->
`1.3.1`](https://renovatebot.com/diffs/npm/vitest/1.1.3/1.3.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/vitest/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vitest/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vitest/1.1.3/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vitest/1.1.3/1.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vitest-dev/vitest (vitest)</summary>

###
[`v1.3.1`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.3.1)

[Compare
Source](https://togithub.com/vitest-dev/vitest/compare/v1.3.0...v1.3.1)

#####    🚀 Features

- **vitest**: Expose parseCLI method  -  by
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5248](https://togithub.com/vitest-dev/vitest/issues/5248)
[<samp>(c793a)</samp>](https://togithub.com/vitest-dev/vitest/commit/c793a136)
- This feature is not affected by SemVer because it is part of an
[experimental API](https://vitest.dev/advanced/api.html).

#####    🐞 Bug Fixes

- Add task tests iteratively  -  by
[@&#8203;DerYeger](https://togithub.com/DerYeger) in
[https://github.com/vitest-dev/vitest/issues/5235](https://togithub.com/vitest-dev/vitest/issues/5235)
[<samp>(38155)</samp>](https://togithub.com/vitest-dev/vitest/commit/38155548)
- **coverage**: Ignore generated TS decorators  -  by
[@&#8203;AriPerkkio](https://togithub.com/AriPerkkio) and
[@&#8203;sheremet-va](https://togithub.com/sheremet-va) in
[https://github.com/vitest-dev/vitest/issues/5206](https://togithub.com/vitest-dev/vitest/issues/5206)
[<samp>(a2804)</samp>](