fix(spy) Fix: vi.spyOn() Compatibility with Google APIs (#3141)#3670
fix(spy) Fix: vi.spyOn() Compatibility with Google APIs (#3141)#3670sheremet-va merged 2 commits intovitest-dev:mainfrom
Conversation
|
|
Maxim-Mazurok
changed the title
|
Can you add tests covering your usecase? |
|
I could try, but are there any d.ts types tests for this package? I couldn't find any |
|
There is test/typescript |
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
I've added a test, this is pretty much how I use it in my project, and you can see the error before my changes on the screenshot below.
I understand that adding 3rd party lib just for the test isn't ideal, but I expect it to be quite challenging to reproduce, hopefully, this is good enough, thanks! |
|
@sheremet-va how does it look? Should I resolve conflicts or abandon PR? |
Sorry for the long wait. If you can resolve conflicts, we can merge this as is. |
Maxim-Mazurok
force-pushed
the
main
branch
3 times, most recently
from
d5edd31 to
3f60594
Compare
2 participants
Types change for @vitest/spy to address this issue: #3141
Applying the same patch I use in my project for a while now, seems to work for me.