fix(ui): Use web hash history in ui (fix #3481) by segevfiner · Pull Request #3487 · vitest-dev/vitest

segevfiner · 2023-06-01T09:45:14Z

bolt-new-by-stackblitz · 2023-06-01T09:45:16Z

Run & review this pull request in StackBlitz Codeflow.

davidbonnet · 2023-06-15T12:52:49Z

This is a nice workaround. Note that refreshing a page leads again to a blank page (but that's an issue with createWebHashHistory).

segevfiner · 2023-06-15T13:09:45Z

That's weird. Shouldn't it read the hash from the URL and work correctly after a refresh? בתאריך יום ה׳, 15 ביוני 2023, 15:53, מאת David Bonnet ‏< ***@***.***>:

…

This is a nice workaround. Note that refreshing a page leads again to a blank page (but that's an issue with createWebHashHistory). — Reply to this email directly, view it on GitHub <#3487 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF4WB75XBIC4FHZAWXRQRVDXLMASZANCNFSM6AAAAAAYWU6DPQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

sheremet-va

Can confirm that it stops working even in dev after page is refreshed.

segevfiner · 2023-08-10T08:36:57Z

Wasn't able to reproduce the failure.

I did:

pnpm build to build vitest
Ran pnpm test -- --reporter html in examples/basic
Ran pnpm vite preview --outDir html in examples/basic
Opened the browser, navigated to one of the tests, hit refresh, it loaded successfully back on this test, the URL uses web hash history as expected.

Was there some bug in createWebHashHistory that might have been fixed in the mean time and have been brought in by the merge 😕

minwe · 2023-08-22T02:39:35Z

Can confirm that it stops working even in dev after page is refreshed.

config HTML as test reporter

export default defineConfig({
  test: {
    reporters: [
      'default',
      'html',
    ],
  }
});

run vitest run --coverage, vitest will output HTML reporter in {projectRoot}/html
start HTTP server like https://www.npmjs.com/package/http-server in project root
open http://127.0.0.1:8080/html, you will get a white page, test reporter content does not render

segevfiner · 2023-08-22T07:57:58Z

Can confirm that it stops working even in dev after page is refreshed.

config HTML as test reporter
export default defineConfig({
  test: {
    reporters: [
      'default',
      'html',
    ],
  }
});
run vitest run --coverage, vitest will output HTML reporter in {projectRoot}/html

start HTTP server like https://www.npmjs.com/package/http-server in project root

open http://127.0.0.1:8080/html, you will get a white page, test reporter content does not render

That happened to me when it used the current @vitest/ui instead of the version in this pull request. I was able to reproduce the refresh issue finally. Now to figure out what causes it cause it kinda looks like an issue in vue-router itself.

netlify · 2023-08-22T08:13:41Z

✅ Deploy Preview for fastidious-cascaron-4ded94 ready!

Name	Link
🔨 Latest commit	`d43e41f`
🔍 Latest deploy log	https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/64e74927241ca90007f5c63a
😎 Deploy Preview	https://deploy-preview-3487--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

segevfiner · 2023-08-22T08:14:36Z

Found it. @vitest/ui also uses useUrlSearchParams, which needs to be configured with the correct mode to match the mode of vue-router. It works now after refresh @davidbonnet @sheremet-va

sheremet-va

Looks good to me 👍🏻

fix(ui): Use web hash history in ui (fix vitest-dev#3481)

fc9ce52

Merge branch 'main' into use-web-hash-history-in-ui

d1d12e8

davidbonnet mentioned this pull request Jun 15, 2023

HTML reporter unusable when hosted with relative pathnames #3219

Closed

6 tasks

sheremet-va requested changes Jul 11, 2023

View reviewed changes

sheremet-va mentioned this pull request Aug 21, 2023

feat: reporter UI using WebHashHistory for better environment compatibility #3991

Closed

6 tasks

Fix UI after refreshing

ce9619d

segevfiner requested a review from sheremet-va August 22, 2023 08:14

Merge branch 'main' into use-web-hash-history-in-ui

d43e41f

sheremet-va approved these changes Aug 24, 2023

View reviewed changes

sheremet-va merged commit 8caabaa into vitest-dev:main Aug 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(ui): Use web hash history in ui (fix #3481)#3487

fix(ui): Use web hash history in ui (fix #3481)#3487
sheremet-va merged 4 commits intovitest-dev:mainfrom
segevfiner:use-web-hash-history-in-ui

segevfiner commented Jun 1, 2023

Uh oh!

bolt-new-by-stackblitz bot commented Jun 1, 2023

Uh oh!

davidbonnet commented Jun 15, 2023

Uh oh!

segevfiner commented Jun 15, 2023 via email

Uh oh!

sheremet-va left a comment

Uh oh!

segevfiner commented Aug 10, 2023

Uh oh!

minwe commented Aug 22, 2023 •

edited

Loading

Uh oh!

segevfiner commented Aug 22, 2023

Uh oh!

netlify bot commented Aug 22, 2023 •

edited

Loading

Uh oh!

segevfiner commented Aug 22, 2023 •

edited

Loading

Uh oh!

sheremet-va left a comment

Uh oh!

Uh oh!

Comments

Conversation

segevfiner commented Jun 1, 2023

Uh oh!

bolt-new-by-stackblitz bot commented Jun 1, 2023

Uh oh!

davidbonnet commented Jun 15, 2023

Uh oh!

segevfiner commented Jun 15, 2023 via email

Uh oh!

sheremet-va left a comment

Choose a reason for hiding this comment

Uh oh!

segevfiner commented Aug 10, 2023

Uh oh!

minwe commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

segevfiner commented Aug 22, 2023

Uh oh!

netlify bot commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fastidious-cascaron-4ded94 ready!

Uh oh!

segevfiner commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sheremet-va left a comment

Choose a reason for hiding this comment

Uh oh!

minwe commented Aug 22, 2023 •

edited

Loading

netlify bot commented Aug 22, 2023 •

edited

Loading

segevfiner commented Aug 22, 2023 •

edited

Loading