chore: test Vite 8.1.3 with stack column fix #10736
Closed
hi-ogawa wants to merge 10 commits into
Closed
Conversation
…e map lookup `parseStacktrace` fed the browser's 1-based `error.stack` column straight into the source map lookup (0-based), then returned the mapped column without converting back. The off-by-one was normally masked by wide mapping segments, but oxc now emits a segment boundary for closing delimiters, so Safari (which anchors call frames at the open paren) could cross into the adjacent segment and drift, causing webkit-only column differences. Subtract 1 before the lookup and add 1 to the result, matching vite's SSR stack rewriter (`ssrStacktrace.ts`). Co-authored-by: OpenCode (claude-opus-4-8) <[email protected]>
Re-baseline the non-browser suites affected by the parseStacktrace column fix (+1 on source-map-remapped stack columns): e2e stacktraces/reporters/ aria snapshots, coverage source-maps, and the UI trace editor cursor. Co-authored-by: OpenCode (claude-opus-4-8) <[email protected]>
Re-baseline browser spec expectations after the parseStacktrace 1-based to 0-based column fix. Columns now resolve to the correct 1-based source position, so chromium/firefox shift by +1 and webkit converges onto the same source column across browsers. Co-authored-by: OpenCode (claude-opus-4-8) <[email protected]>
After the stacktrace column fix, several browser-specific expectations resolve to the same source column. Collapse the webkit/else branches in playwright-trace-mark and remove the duplicated safari branch in the "logs have stack traces" runner test. Co-authored-by: OpenCode (claude-opus-4-8) <[email protected]>
The non-rolldown webkit branches (nested under `if (rolldownVersion)`) were not exercised by the rolldown-vite run used to re-baseline, so they kept pre-fix columns and would fail the vite@7 CI job. Verified against a local `vite@7` (non-rolldown) run: they converge to the same source column as the rolldown/other-browser branches. Co-authored-by: OpenCode (claude-opus-4-8) <[email protected]>
With the stacktrace column fix, the rolldown and non-rolldown stack columns resolve to the same source position, so the `if (rolldownVersion)` branches in aria-snapshot, errors, playwright-trace-mark and the runner timeout-hooks test are now redundant. Collapse them into a single snapshot each and drop the unused `rolldownVersion` imports. Verified on both rolldown-vite and vite@7 (non-rolldown) runs. Co-authored-by: OpenCode (claude-opus-4-8) <[email protected]>
Co-authored-by: OpenCode <[email protected]>
…e' into test/vite-8.1-stack-column
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.