Description

While digging through #10723 (comment), apparently our parseStacktrace + getSourceMap is the one with off-by-one column issue.

Note that we do this combination of parseStacktrace + getSourceMap only for browser mode error mapping on the server and for external module error, so it may not be too surprising to discover this just now.

For example,

• 🙅 before

$ VITE_FAIL_TEST=1 pnpm -C examples/lit test --browser.headless
...

 ❯ test/basic.test.ts:19:72
     17|     await expect.element(page.getByRole('button')).toMatchTextContent('2')
     18|     if (import.meta.env.VITE_FAIL_TEST) {
     19|       await expect.element(page.getByRole('button'), { timeout: 3000 }).toMatchTextContent('3')
       |                                                                        ^
     20|     }
     21|   })

Caused by: Error: Matcher did not succeed in time.
 ❯ test/basic.test.ts:19:6

• ✅ after

$ VITE_FAIL_TEST=1 pnpm -C examples/lit test --browser.headless
...

 ❯ test/basic.test.ts:19:73
     17|     await expect.element(page.getByRole('button')).toMatchTextContent('2')
     18|     if (import.meta.env.VITE_FAIL_TEST) {
     19|       await expect.element(page.getByRole('button'), { timeout: 3000 }).toMatchTextContent('3')
       |                                                                         ^
     20|     }
     21|   })

Caused by: Error: Matcher did not succeed in time.
 ❯ test/basic.test.ts:19:7

After this change, many old branches of isRolldown / webkit converges with existing chrome/firefox column location, so test snapshots are unified. There are still remaining divergence for webkit but they look mostly cosmetic.

  await myEqualAsync('async', 'x')
  ^     ^
  C     Firefox/WebKit
  3     9

  throw new Error('error')
        ^   ^
        C/F WebKit
         9   13

  const error = new Error('Custom error for stack trace')
                ^   ^
                C/F WebKit
                17   21

    throw new Error('custom_unhandled_error')
          ^   ^
          all WebKit-only extra frame
          11  15

  throw new Error('error from b')
        ^        ^
        C/F      WebKit
         9        18

  return a() + b()
               ^^
               |└─ WebKit: 17, opening parenthesis
               └── C/F:    16, function name

TODO

• verify it with latest Vite chore: test Vite 8.1.3 with stack column fix  #10736
• this parseStacktrace is also used for Vite forwardConsole https://vite.dev/config/server-options#server-forwardconsole. They need to update their test after the bump.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
• Ideally, include a test that fails without this PR but passes with it.
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
• Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

• Run the tests with pnpm test:ci.

Documentation

• If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.