test: update stacktrace column snapshots for imported-binding call sites#10722
Closed
hi-ogawa wants to merge 6 commits into
Closed
test: update stacktrace column snapshots for imported-binding call sites#10722hi-ogawa wants to merge 6 commits into
hi-ogawa wants to merge 6 commits into
Conversation
Vite's SSR transform now maps the call-site column of imported bindings to the callee start (aligning with Node) instead of the argument-list `(`. Update the e2e stacktrace snapshots to the Node-aligned columns. Co-authored-by: OpenCode (claude-opus-4-8) <[email protected]>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Validate the updated stacktrace snapshots against the Vite SSR call-site column fix (vitejs/vite#22829, commit e65ff84). Disable blockExoticSubdeps so the URL-resolved vite is allowed as a subdep. Co-authored-by: OpenCode (claude-opus-4-8) <[email protected]>
pnpm 11 rejects a tarball lockfile entry with no `integrity` field under frozen/trusted install (ERR_PNPM_MISSING_TARBALL_INTEGRITY), which broke CI install. There's no flag to disable that check, so record the tarball's sha512 SRI instead; pnpm then verifies the download and passes. Co-authored-by: OpenCode (claude-opus-4-8) <[email protected]>
This was referenced Jul 7, 2026
Collaborator
Author
|
superseded by #10770 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vitejs/vite#22829 updates SSR transform to align stacktrace better with Node. This PR updates tests to match with new location for some error stacktrace.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.