Skip to content

fix: don't print column in test names when includeTaskLocation is enabled#10681

Merged
sheremet-va merged 2 commits into
mainfrom
fix/reporter-don-tprint-column
Jul 1, 2026
Merged

fix: don't print column in test names when includeTaskLocation is enabled#10681
sheremet-va merged 2 commits into
mainfrom
fix/reporter-don-tprint-column

Conversation

@sheremet-va

@sheremet-va sheremet-va commented Jun 30, 2026

Copy link
Copy Markdown
Member

Vitest doesn't support file:line:column format when running tests, so one always has to manually remove the column when copying the path. Instead, let's just only print the line. Column is usually irrelevant anyway

@netlify

netlify Bot commented Jun 30, 2026

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 144aeb6
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6a4398504fbfb60008ddbf02
😎 Deploy Preview https://deploy-preview-10681--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa
hi-ogawa reviewed Jun 30, 2026
View reviewed changes

@hi-ogawa hi-ogawa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot tell where this change shows up exactly. This isn't the error stack line:column right? Is this only for display side of includeTaskLocation?

@sheremet-va

sheremet-va commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Cannot tell where this change shows up exactly. This isn't the error stack line:column right? Is this only for display side of includeTaskLocation?

Yes. We print the location in verbose reporter if includeTaskLocation is enabled, and also in the "Errors" section when we print the name of the test

hi-ogawa
hi-ogawa approved these changes Jul 1, 2026
View reviewed changes

@hi-ogawa hi-ogawa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine and doesn't change much anyway since the column is just test/it indentation.

@hi-ogawa

hi-ogawa commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Can you update PR title to mention includeTaskLocation so it won't mislead as general errors display?

@sheremet-va sheremet-va changed the title fix: don't print test column fix: don't print test column when includeTaskLocation is enabled Jul 1, 2026
@sheremet-va sheremet-va changed the title fix: don't print test column when includeTaskLocation is enabled fix: don't print column in test names when includeTaskLocation is enabled Jul 1, 2026
@sheremet-va
sheremet-va merged commit bd9cc9d into main Jul 1, 2026
29 of 30 checks passed
@sheremet-va
sheremet-va deleted the fix/reporter-don-tprint-column branch July 1, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hi-ogawa hi-ogawa hi-ogawa approved these changes
@AriPerkkio AriPerkkio Awaiting requested review from AriPerkkio

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sheremet-va @hi-ogawa