refactor!: remove webdriverio package#10675
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| "@vitest/browser-playwright": "workspace:*", | ||
| "@vitest/browser-preview": "workspace:*", | ||
| "@vitest/browser-webdriverio": "workspace:*", | ||
| "@vitest/browser-webdriverio": "^5.0.0-beta.5 || >=5.0.0", |
There was a problem hiding this comment.
I forgot why browser is peer dep. Don't we want to eventually remove webdriverio one at least otherwise version bump seems messy.
There was a problem hiding this comment.
vitest/browser exports from the webdriverio. without it, the types are not populated. I am not sure if there is a better way
There was a problem hiding this comment.
Oh that one. Then it's fine for another day in the future.
There was a problem hiding this comment.
We don't actually add or extend any type through this though
And actual semi-automatic type extension is through main provider import such as
vitest/packages/browser-playwright/src/playwright.ts
Lines 650 to 651 in d20aa66
It looks like vitest should have just @vitest/browser as optional peer dep instead of all three. Not sure what I may be missing.
There was a problem hiding this comment.
If we do that, then extra types from providers won't be picked up (like options)
| - webdriverio@9.29.1 | ||
| - webdriver@9.29.1 | ||
| - '@wdio/types@9.29.1' | ||
| - '@wdio/[email protected]' | ||
| - '@wdio/utils@9.20.0' | ||
| - '@wdio/config@9.20.0' | ||
| - '@wdio/logger@9.18.0' | ||
| - '@wdio/protocols@9.16.2' | ||
| - '@wdio/utils@9.29.1' | ||
| - '@wdio/config@9.29.1' | ||
| - '@wdio/logger@9.29.1' | ||
| - '@wdio/protocols@9.29.1' |
hi-ogawa
left a comment
hi-ogawa
left a comment
There was a problem hiding this comment.
Also as we discussed, we still have webdriverio branch in core but removing/reworking these are out of scope. Just surfacing these for posterity:
packages/browser/src/node/rpc.ts:323—switchContextRPC gated toprovider.name !== 'webdriverio'.packages/vitest/src/node/pools/browser.ts:459—shouldIgnoreDebuggerspecial-caseswebdriverio(chrome/edge only).packages/browser/src/client/tester/tester.ts:185— a non-trivial iframe context-switch block that runs only whenserver.provider === 'webdriverio'.packages/browser/src/client/tester/tester-utils.ts:90— shadow-DOM>>>selector prefix only for webdriverio.packages/browser/src/client/tester/context.ts:50— keyboard modifier maps webdriverio →Ctrl.packages/browser/src/client/tester/logger.ts:100— filters[WDIO]shadow-root logs.
|
Btw, in what sense is this breaking? (meaning anything to mention as v5 breaking?) |
Hm, it is not breaking, right 🤔 |
3 participants
webdriverio provider now lives in https://github.com/vitest-community/vitest-webdriverio