fix(browser): resize the browser ui only if it's not headless#10662
Merged
Conversation
macarie
approved these changes
Jun 25, 2026
macarie
left a comment
macarie
left a comment
Member
There was a problem hiding this comment.
I guess it makes sense, even tho I don't think anyone would run with UI enabled but headless, or at least I hope 😅
It works on my machine™ (and CI?) so I wonder why the test fails tho. What are the sizes of the two screenshots?
Also, do you have this option (Appearance → Windows, at the bottom) set to "Always"?
Member
Author
The size is just doubled, the device pixel ratio on retina kicks in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that this test always fails locally on Mac with Webkit reporting a different resolution:
vitest/test/browser/specs/to-match-screenshot.test.ts
Line 284 in a60ded0