Skip to content

fix(vm): fix external module resolve error with deps optimizer query for encoded URI [backport to v4]#10661

Merged
hi-ogawa merged 2 commits into
vitest-dev:v4from
SveLil:v4
Jun 30, 2026
Merged

fix(vm): fix external module resolve error with deps optimizer query for encoded URI [backport to v4]#10661
hi-ogawa merged 2 commits into
vitest-dev:v4from
SveLil:v4

Conversation

@SveLil

@SveLil SveLil commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Resolves #10657 for v4

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • x ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa hi-ogawa changed the title fix(vm): fix cachedResolver encoding URIs (fix #10658) fix(vm): fix cachedResolver encoding URIs [backport to v4] Jun 26, 2026
@hi-ogawa hi-ogawa changed the title fix(vm): fix cachedResolver encoding URIs [backport to v4] fix(vm): fix external module resolve error with deps optimizer query for encoded URI [backport to v4] Jun 26, 2026

@hi-ogawa hi-ogawa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 24 playwright download stuck on CI but can ignore.

@hi-ogawa
hi-ogawa merged commit bae52b5 into vitest-dev:v4 Jun 30, 2026
13 of 15 checks passed
vitbokisch added a commit to pyreon/pyreon that referenced this pull request Jul 16, 2026
… <Example>

vitest 4.1.10 (+ @vitest/browser, @vitest/browser-playwright,
@vitest/coverage-v8) deterministically fails 8 @pyreon/zero-content
specs in BOTH the happy-dom suite (components.test.tsx Callout
rich-children, example.browser.test.tsx Example mount + all share-key
specs) AND the real-Chromium harness — the exact two red required
checks on this PR (test (zero) + Test (browser)).

Bisect-verified in both directions:
- vite 8.0.16 + vitest 4.1.10 -> FAIL (8 specs)  [vite exonerated]
- vite 8.0.16 + vitest 4.1.9  -> PASS
- vite 8.1.5  + vitest 4.1.9  -> PASS 743/743 node + 37/37 Chromium

v4.1.10 ships exactly two fixes; the VM deps-optimizer
encoded-URI module-resolve change (vitest-dev/vitest#10661) is the
plausible interaction with <Example>'s dynamic loader registry.
Root-causing vitest internals is out of scope for a deps PR — the
single bump is reverted (declarations restored to origin/main
values), everything else in the batch stays.

Re-verified on the final combination: zero cell green (zero 1679,
zero-cli 21, create-zero 103, zero-content 743 + 37 browser),
validate-fast 15/15.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants