fix(vm): fix external module resolve error with deps optimizer query for encoded URI [backport to v4]#10661
Merged
Conversation
6 tasks
hi-ogawa
approved these changes
Jun 26, 2026
hi-ogawa
left a comment
Collaborator
There was a problem hiding this comment.
Node 24 playwright download stuck on CI but can ignore.
hi-ogawa
approved these changes
Jun 26, 2026
7 tasks
This was referenced Jul 10, 2026
vitbokisch
added a commit
to pyreon/pyreon
that referenced
this pull request
Jul 16, 2026
… <Example> vitest 4.1.10 (+ @vitest/browser, @vitest/browser-playwright, @vitest/coverage-v8) deterministically fails 8 @pyreon/zero-content specs in BOTH the happy-dom suite (components.test.tsx Callout rich-children, example.browser.test.tsx Example mount + all share-key specs) AND the real-Chromium harness — the exact two red required checks on this PR (test (zero) + Test (browser)). Bisect-verified in both directions: - vite 8.0.16 + vitest 4.1.10 -> FAIL (8 specs) [vite exonerated] - vite 8.0.16 + vitest 4.1.9 -> PASS - vite 8.1.5 + vitest 4.1.9 -> PASS 743/743 node + 37/37 Chromium v4.1.10 ships exactly two fixes; the VM deps-optimizer encoded-URI module-resolve change (vitest-dev/vitest#10661) is the plausible interaction with <Example>'s dynamic loader registry. Root-causing vitest internals is out of scope for a deps PR — the single bump is reverted (declarations restored to origin/main values), everything else in the batch stays. Re-verified on the final combination: zero cell green (zero 1679, zero-cli 21, create-zero 103, zero-content 743 + 37 browser), validate-fast 15/15. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #10657 for v4
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.